[activemq-dev] Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[activemq-dev] Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

James Strachan-2
Its bugged me a little for a while that the core destination classes  
are part of the JMS client API and so should be in the org.activemq  
package like the rest of the classes (ActiveMQConnectionFactory etc).  
I wonder, since these classes have moved in 4.x to the command  
package anyway (and they are not really commands), now could be a  
good time to move them into the org.activemq package?

Thoughts?

James
-------
http://radio.weblogs.com/0112098/

Reply | Threaded
Open this post in threaded view
|

Re: [activemq-dev] Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

chirino
Hi James,

That sounds like a good idea.  I even tried to do it one but ran into  
problems with the openwire generation scripts.  They seem to expect  
all the commands to be in one directory.

Regards,
Hiram

On Nov 23, 2005, at 5:11 AM, James Strachan wrote:

> Its bugged me a little for a while that the core destination  
> classes are part of the JMS client API and so should be in the  
> org.activemq package like the rest of the classes  
> (ActiveMQConnectionFactory etc). I wonder, since these classes have  
> moved in 4.x to the command package anyway (and they are not really  
> commands), now could be a good time to move them into the  
> org.activemq package?
>
> Thoughts?
>
> James
> -------
> http://radio.weblogs.com/0112098/
>

Reply | Threaded
Open this post in threaded view
|

[activemq-dev] Re: Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

Dennis Cook
Hiram,

I have a related question.  When I added the brokerName member to the
broker info class I made manual updates to the openwire marshalling
class.  Was the the correct approach, or are these classes auto
generated?  I did not find any generation scripts.

Dennis


Hiram Chirino wrote:

> Hi James,
>
> That sounds like a good idea.  I even tried to do it one but ran into  
> problems with the openwire generation scripts.  They seem to expect  all
> the commands to be in one directory.
>
> Regards,
> Hiram
>
> On Nov 23, 2005, at 5:11 AM, James Strachan wrote:
>
>> Its bugged me a little for a while that the core destination  classes
>> are part of the JMS client API and so should be in the  org.activemq
>> package like the rest of the classes  (ActiveMQConnectionFactory etc).
>> I wonder, since these classes have  moved in 4.x to the command
>> package anyway (and they are not really  commands), now could be a
>> good time to move them into the  org.activemq package?
>>
>> Thoughts?
>>
>> James
>> -------
>> http://radio.weblogs.com/0112098/
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [activemq-dev] Re: Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

chirino
Hi Dennis,

Yep, those are auto-generated.  I just check, and you did the most  
important thing which is to include the @openwire:property comment on  
the getter of property.  Once that's done, just run:
maven openwire:generate

In the activemq-core directory.  That should generate both the java  
and c marshalers.

Regards,
Hiram


On Nov 23, 2005, at 12:54 PM, Dennis Cook wrote:

> Hiram,
>
> I have a related question.  When I added the brokerName member to  
> the broker info class I made manual updates to the openwire  
> marshalling class.  Was the the correct approach, or are these  
> classes auto generated?  I did not find any generation scripts.
>
> Dennis
>
>
> Hiram Chirino wrote:
>
>> Hi James,
>> That sounds like a good idea.  I even tried to do it one but ran  
>> into  problems with the openwire generation scripts.  They seem to  
>> expect  all the commands to be in one directory.
>> Regards,
>> Hiram
>> On Nov 23, 2005, at 5:11 AM, James Strachan wrote:
>>
>>> Its bugged me a little for a while that the core destination  
>>> classes are part of the JMS client API and so should be in the  
>>> org.activemq package like the rest of the classes  
>>> (ActiveMQConnectionFactory etc). I wonder, since these classes  
>>> have  moved in 4.x to the command package anyway (and they are  
>>> not really  commands), now could be a good time to move them into  
>>> the  org.activemq package?
>>>
>>> Thoughts?
>>>
>>> James
>>> -------
>>> http://radio.weblogs.com/0112098/
>>>
>

Reply | Threaded
Open this post in threaded view
|

[activemq-dev] Re: Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

Dennis Cook
Ah, so that is the magic.  That explains why the marshalling code was
missing for the ControlCommand command member.  It is missing the
@openwire:property comment.

However, when I try to run the code generation goal, I get the following
error:

C:\development\amq-br4\activemq-core>maven openwire:generate
  __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0.2

Attempting to download activemq-jaas-4.0-SNAPSHOT.jar.
Attempting to download activecluster-1.1-SNAPSHOT.jar.
Attempting to download activeio-2.1-SNAPSHOT.jar.
Attempting to download xbean-spring-2.0-SNAPSHOT.jar.
Attempting to download gram-1.1-SNAPSHOT.jar.
build:start:

openwire:generate:
     [mkdir] Created dir:
C:\development\amq-br4\activemq-core\target\gram-classes
     [javac] Compiling 1 source file to
C:\development\amq-br4\activemq-core\target\gram-classes
     [java] Parsing source files in directory:
src/main/java/org/activemq/command
     [java] Exception in thread "main" java.lang.NoClassDefFoundError:
com/sun/javadoc/Type
     [java]      at
org.codehaus.jam.provider.JamServiceFactoryImpl.createSourceBuilder(JamServiceFactoryImpl.java:205)
     [java]      at
org.codehaus.jam.provider.JamServiceFactoryImpl.createBuilder(JamServiceFactoryImpl.java:158)
     [java]      at
org.codehaus.jam.provider.JamServiceFactoryImpl.createClassLoader(JamServiceFactoryImpl.java:137)
     [java]      at
org.codehaus.jam.provider.JamServiceFactoryImpl.createService(JamServiceFactoryImpl.java:78)
     [java]      at org.codehaus.gram.Gram.main(Gram.java:33)
     [java] [ERROR] Java Result: 1
BUILD SUCCESSFUL
Total time: 8 seconds
Finished at: Wed Nov 23 14:46:27 PST 2005


Hiram Chirino wrote:

> Hi Dennis,
>
> Yep, those are auto-generated.  I just check, and you did the most  
> important thing which is to include the @openwire:property comment on  
> the getter of property.  Once that's done, just run:
> maven openwire:generate
>
> In the activemq-core directory.  That should generate both the java  and
> c marshalers.
>
> Regards,
> Hiram
>
>
> On Nov 23, 2005, at 12:54 PM, Dennis Cook wrote:
>
>> Hiram,
>>
>> I have a related question.  When I added the brokerName member to  the
>> broker info class I made manual updates to the openwire  marshalling
>> class.  Was the the correct approach, or are these  classes auto
>> generated?  I did not find any generation scripts.
>>
>> Dennis
>>
>>
>> Hiram Chirino wrote:
>>
>>> Hi James,
>>> That sounds like a good idea.  I even tried to do it one but ran  
>>> into  problems with the openwire generation scripts.  They seem to  
>>> expect  all the commands to be in one directory.
>>> Regards,
>>> Hiram
>>> On Nov 23, 2005, at 5:11 AM, James Strachan wrote:
>>>
>>>> Its bugged me a little for a while that the core destination  
>>>> classes are part of the JMS client API and so should be in the  
>>>> org.activemq package like the rest of the classes  
>>>> (ActiveMQConnectionFactory etc). I wonder, since these classes  
>>>> have  moved in 4.x to the command package anyway (and they are  not
>>>> really  commands), now could be a good time to move them into  the  
>>>> org.activemq package?
>>>>
>>>> Thoughts?
>>>>
>>>> James
>>>> -------
>>>> http://radio.weblogs.com/0112098/
>>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [activemq-dev] Re: Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

chirino
Hum, that's odd.  It works for me on OS X on java 1.4 and 1.5 using  
maven 1.0.2.  I'll have to boot up my windows machine and check to  
see if it works there too.  What are you on?

Regards,
Hiram


On Nov 23, 2005, at 5:48 PM, Dennis Cook wrote:

> Ah, so that is the magic.  That explains why the marshalling code  
> was missing for the ControlCommand command member.  It is missing  
> the @openwire:property comment.
>
> However, when I try to run the code generation goal, I get the  
> following error:
>
> C:\development\amq-br4\activemq-core>maven openwire:generate
>  __  __
> |  \/  |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
>
> Attempting to download activemq-jaas-4.0-SNAPSHOT.jar.
> Attempting to download activecluster-1.1-SNAPSHOT.jar.
> Attempting to download activeio-2.1-SNAPSHOT.jar.
> Attempting to download xbean-spring-2.0-SNAPSHOT.jar.
> Attempting to download gram-1.1-SNAPSHOT.jar.
> build:start:
>
> openwire:generate:
>     [mkdir] Created dir: C:\development\amq-br4\activemq-core\target
> \gram-classes
>     [javac] Compiling 1 source file to C:\development\amq-br4
> \activemq-core\target\gram-classes
>     [java] Parsing source files in directory: src/main/java/org/
> activemq/command
>     [java] Exception in thread "main"  
> java.lang.NoClassDefFoundError: com/sun/javadoc/Type
>     [java]      at  
> org.codehaus.jam.provider.JamServiceFactoryImpl.createSourceBuilder
> (JamServiceFactoryImpl.java:205)
>     [java]      at  
> org.codehaus.jam.provider.JamServiceFactoryImpl.createBuilder
> (JamServiceFactoryImpl.java:158)
>     [java]      at  
> org.codehaus.jam.provider.JamServiceFactoryImpl.createClassLoader
> (JamServiceFactoryImpl.java:137)
>     [java]      at  
> org.codehaus.jam.provider.JamServiceFactoryImpl.createService
> (JamServiceFactoryImpl.java:78)
>     [java]      at org.codehaus.gram.Gram.main(Gram.java:33)
>     [java] [ERROR] Java Result: 1
> BUILD SUCCESSFUL
> Total time: 8 seconds
> Finished at: Wed Nov 23 14:46:27 PST 2005
>
>
> Hiram Chirino wrote:
>
>> Hi Dennis,
>> Yep, those are auto-generated.  I just check, and you did the  
>> most  important thing which is to include the @openwire:property  
>> comment on  the getter of property.  Once that's done, just run:
>> maven openwire:generate
>> In the activemq-core directory.  That should generate both the  
>> java  and c marshalers.
>> Regards,
>> Hiram
>> On Nov 23, 2005, at 12:54 PM, Dennis Cook wrote:
>>
>>> Hiram,
>>>
>>> I have a related question.  When I added the brokerName member  
>>> to  the broker info class I made manual updates to the openwire  
>>> marshalling class.  Was the the correct approach, or are these  
>>> classes auto generated?  I did not find any generation scripts.
>>>
>>> Dennis
>>>
>>>
>>> Hiram Chirino wrote:
>>>
>>>
>>>> Hi James,
>>>> That sounds like a good idea.  I even tried to do it one but  
>>>> ran  into  problems with the openwire generation scripts.  They  
>>>> seem to  expect  all the commands to be in one directory.
>>>> Regards,
>>>> Hiram
>>>> On Nov 23, 2005, at 5:11 AM, James Strachan wrote:
>>>>
>>>>
>>>>> Its bugged me a little for a while that the core destination    
>>>>> classes are part of the JMS client API and so should be in  
>>>>> the   org.activemq package like the rest of the classes    
>>>>> (ActiveMQConnectionFactory etc). I wonder, since these classes  
>>>>> have  moved in 4.x to the command package anyway (and they are  
>>>>> not really  commands), now could be a good time to move them  
>>>>> into  the  org.activemq package?
>>>>>
>>>>> Thoughts?
>>>>>
>>>>> James
>>>>> -------
>>>>> http://radio.weblogs.com/0112098/
>>>>>
>>>>>
>>>
>

Reply | Threaded
Open this post in threaded view
|

[activemq-dev] Re: Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

Dennis Cook
Here at work I am using W2K professional.  I will try it on my XP box
when I get home tonight.


Hiram Chirino wrote:

> Hum, that's odd.  It works for me on OS X on java 1.4 and 1.5 using  
> maven 1.0.2.  I'll have to boot up my windows machine and check to  see
> if it works there too.  What are you on?
>
> Regards,
> Hiram
>
>
> On Nov 23, 2005, at 5:48 PM, Dennis Cook wrote:
>
>> Ah, so that is the magic.  That explains why the marshalling code  was
>> missing for the ControlCommand command member.  It is missing  the
>> @openwire:property comment.
>>
>> However, when I try to run the code generation goal, I get the  
>> following error:
>>
>> C:\development\amq-br4\activemq-core>maven openwire:generate
>>  __  __
>> |  \/  |__ _Apache__ ___
>> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
>> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
>>
>> Attempting to download activemq-jaas-4.0-SNAPSHOT.jar.
>> Attempting to download activecluster-1.1-SNAPSHOT.jar.
>> Attempting to download activeio-2.1-SNAPSHOT.jar.
>> Attempting to download xbean-spring-2.0-SNAPSHOT.jar.
>> Attempting to download gram-1.1-SNAPSHOT.jar.
>> build:start:
>>
>> openwire:generate:
>>     [mkdir] Created dir: C:\development\amq-br4\activemq-core\target
>> \gram-classes
>>     [javac] Compiling 1 source file to C:\development\amq-br4
>> \activemq-core\target\gram-classes
>>     [java] Parsing source files in directory: src/main/java/org/
>> activemq/command
>>     [java] Exception in thread "main"  java.lang.NoClassDefFoundError:
>> com/sun/javadoc/Type
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createSourceBuilder
>> (JamServiceFactoryImpl.java:205)
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createBuilder
>> (JamServiceFactoryImpl.java:158)
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createClassLoader
>> (JamServiceFactoryImpl.java:137)
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createService
>> (JamServiceFactoryImpl.java:78)
>>     [java]      at org.codehaus.gram.Gram.main(Gram.java:33)
>>     [java] [ERROR] Java Result: 1
>> BUILD SUCCESSFUL
>> Total time: 8 seconds
>> Finished at: Wed Nov 23 14:46:27 PST 2005
>>
>>
>> Hiram Chirino wrote:
>>
>>> Hi Dennis,
>>> Yep, those are auto-generated.  I just check, and you did the  most  
>>> important thing which is to include the @openwire:property  comment
>>> on  the getter of property.  Once that's done, just run:
>>> maven openwire:generate
>>> In the activemq-core directory.  That should generate both the  java  
>>> and c marshalers.
>>> Regards,
>>> Hiram
>>> On Nov 23, 2005, at 12:54 PM, Dennis Cook wrote:
>>>
>>>> Hiram,
>>>>
>>>> I have a related question.  When I added the brokerName member  to  
>>>> the broker info class I made manual updates to the openwire  
>>>> marshalling class.  Was the the correct approach, or are these  
>>>> classes auto generated?  I did not find any generation scripts.
>>>>
>>>> Dennis
>>>>
>>>>
>>>> Hiram Chirino wrote:
>>>>
>>>>
>>>>> Hi James,
>>>>> That sounds like a good idea.  I even tried to do it one but  ran  
>>>>> into  problems with the openwire generation scripts.  They  seem
>>>>> to  expect  all the commands to be in one directory.
>>>>> Regards,
>>>>> Hiram
>>>>> On Nov 23, 2005, at 5:11 AM, James Strachan wrote:
>>>>>
>>>>>
>>>>>> Its bugged me a little for a while that the core destination    
>>>>>> classes are part of the JMS client API and so should be in  the  
>>>>>> org.activemq package like the rest of the classes    
>>>>>> (ActiveMQConnectionFactory etc). I wonder, since these classes  
>>>>>> have  moved in 4.x to the command package anyway (and they are  
>>>>>> not really  commands), now could be a good time to move them  
>>>>>> into  the  org.activemq package?
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> James
>>>>>> -------
>>>>>> http://radio.weblogs.com/0112098/
>>>>>>
>>>>>>
>>>>
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [activemq-dev] Re: Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

James Strachan-2
In reply to this post by chirino
On 23 Nov 2005, at 20:05, Hiram Chirino wrote:
> Hi Dennis,
>
> Yep, those are auto-generated.  I just check, and you did the most  
> important thing which is to include the @openwire:property comment  
> on the getter of property.  Once that's done, just run:
> maven openwire:generate
>
> In the activemq-core directory.  That should generate both the java  
> and c marshalers.

BTW the new auto-generated classes should then be checked into SVN  
for others to reuse too.

James
-------
http://radio.weblogs.com/0112098/

Reply | Threaded
Open this post in threaded view
|

[activemq-dev] Re: Moving ActiveMQDestination, ActiveMQTopic, ActiveMQQueue to org.activemq?

Dennis Cook
In reply to this post by chirino
Hiram,

FYI,  I moved the tools.jar into the jre/lib/ext directory and the
generation phase works now.

Dennis

Hiram Chirino wrote:

> Hum, that's odd.  It works for me on OS X on java 1.4 and 1.5 using  
> maven 1.0.2.  I'll have to boot up my windows machine and check to  see
> if it works there too.  What are you on?
>
> Regards,
> Hiram
>
>
> On Nov 23, 2005, at 5:48 PM, Dennis Cook wrote:
>
>> Ah, so that is the magic.  That explains why the marshalling code  was
>> missing for the ControlCommand command member.  It is missing  the
>> @openwire:property comment.
>>
>> However, when I try to run the code generation goal, I get the  
>> following error:
>>
>> C:\development\amq-br4\activemq-core>maven openwire:generate
>>  __  __
>> |  \/  |__ _Apache__ ___
>> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
>> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
>>
>> Attempting to download activemq-jaas-4.0-SNAPSHOT.jar.
>> Attempting to download activecluster-1.1-SNAPSHOT.jar.
>> Attempting to download activeio-2.1-SNAPSHOT.jar.
>> Attempting to download xbean-spring-2.0-SNAPSHOT.jar.
>> Attempting to download gram-1.1-SNAPSHOT.jar.
>> build:start:
>>
>> openwire:generate:
>>     [mkdir] Created dir: C:\development\amq-br4\activemq-core\target
>> \gram-classes
>>     [javac] Compiling 1 source file to C:\development\amq-br4
>> \activemq-core\target\gram-classes
>>     [java] Parsing source files in directory: src/main/java/org/
>> activemq/command
>>     [java] Exception in thread "main"  java.lang.NoClassDefFoundError:
>> com/sun/javadoc/Type
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createSourceBuilder
>> (JamServiceFactoryImpl.java:205)
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createBuilder
>> (JamServiceFactoryImpl.java:158)
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createClassLoader
>> (JamServiceFactoryImpl.java:137)
>>     [java]      at  
>> org.codehaus.jam.provider.JamServiceFactoryImpl.createService
>> (JamServiceFactoryImpl.java:78)
>>     [java]      at org.codehaus.gram.Gram.main(Gram.java:33)
>>     [java] [ERROR] Java Result: 1
>> BUILD SUCCESSFUL
>> Total time: 8 seconds
>> Finished at: Wed Nov 23 14:46:27 PST 2005
>>
>>
>> Hiram Chirino wrote:
>>
>>> Hi Dennis,
>>> Yep, those are auto-generated.  I just check, and you did the  most  
>>> important thing which is to include the @openwire:property  comment
>>> on  the getter of property.  Once that's done, just run:
>>> maven openwire:generate
>>> In the activemq-core directory.  That should generate both the  java  
>>> and c marshalers.
>>> Regards,
>>> Hiram
>>> On Nov 23, 2005, at 12:54 PM, Dennis Cook wrote:
>>>
>>>> Hiram,
>>>>
>>>> I have a related question.  When I added the brokerName member  to  
>>>> the broker info class I made manual updates to the openwire  
>>>> marshalling class.  Was the the correct approach, or are these  
>>>> classes auto generated?  I did not find any generation scripts.
>>>>
>>>> Dennis
>>>>
>>>>
>>>> Hiram Chirino wrote:
>>>>
>>>>
>>>>> Hi James,
>>>>> That sounds like a good idea.  I even tried to do it one but  ran  
>>>>> into  problems with the openwire generation scripts.  They  seem
>>>>> to  expect  all the commands to be in one directory.
>>>>> Regards,
>>>>> Hiram
>>>>> On Nov 23, 2005, at 5:11 AM, James Strachan wrote:
>>>>>
>>>>>
>>>>>> Its bugged me a little for a while that the core destination    
>>>>>> classes are part of the JMS client API and so should be in  the  
>>>>>> org.activemq package like the rest of the classes    
>>>>>> (ActiveMQConnectionFactory etc). I wonder, since these classes  
>>>>>> have  moved in 4.x to the command package anyway (and they are  
>>>>>> not really  commands), now could be a good time to move them  
>>>>>> into  the  org.activemq package?
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> James
>>>>>> -------
>>>>>> http://radio.weblogs.com/0112098/
>>>>>>
>>>>>>
>>>>
>>
>
>