activemq-artemis git commit: ARTEMIS-1980 Warn on failed check of table existence should be info

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

activemq-artemis git commit: ARTEMIS-1980 Warn on failed check of table existence should be info

nigrofranz
Repository: activemq-artemis
Updated Branches:
  refs/heads/2.6.x 65213ebef -> 1fef3dcc4


ARTEMIS-1980 Warn on failed check of table existence should be info

DB2 metadata checks should erroneously report stale table existence on
not existing/just deleted table, making the subsequent warning logs
of failed SELECT COUNT useless and scaring: should be better to let
them lowered to INFO level

(cherry picked from commit 46542fb230a31d621be9cdf4140df998d6dc3903)


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/1fef3dcc
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/1fef3dcc
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/1fef3dcc

Branch: refs/heads/2.6.x
Commit: 1fef3dcc45f2b7ea9dc846d762a01bc97058fc3a
Parents: 65213eb
Author: Francesco Nigro <[hidden email]>
Authored: Thu Jul 12 15:14:37 2018 +0200
Committer: Francesco Nigro <[hidden email]>
Committed: Sun Nov 4 22:57:50 2018 +0100

----------------------------------------------------------------------
 .../artemis/jdbc/store/drivers/AbstractJDBCDriver.java        | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/1fef3dcc/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
----------------------------------------------------------------------
diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
index ceb0967..2118942 100644
--- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
+++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
@@ -242,7 +242,12 @@ public abstract class AbstractJDBCDriver {
                   }
                }
             } catch (SQLException e) {
-               logger.warn(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't verify the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
+               //that's not a real issue and do not deserve any user-level log:
+               //some DBMS just return stale information about table existence
+               //and can fail on later attempts to access them
+               if (logger.isTraceEnabled()) {
+                  logger.trace(JDBCUtils.appendSQLExceptionDetails(new StringBuilder("Can't verify the initialization of table ").append(tableName).append(" due to:"), e, sqlProvider.getCountJournalRecordsSQL()));
+               }
                try {
                   connection.rollback();
                } catch (SQLException rollbackEx) {