activemq-artemis git commit: ARTEMIS-1114 Improving some comment

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

activemq-artemis git commit: ARTEMIS-1114 Improving some comment

clebertsuconic-2
Repository: activemq-artemis
Updated Branches:
  refs/heads/1.x ec9615a01 -> 3076b84c7


ARTEMIS-1114 Improving some comment


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/3076b84c
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/3076b84c
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/3076b84c

Branch: refs/heads/1.x
Commit: 3076b84c71c3463eff28d2290bf8f59895516d62
Parents: ec9615a
Author: Clebert Suconic <[hidden email]>
Authored: Fri Apr 14 18:07:09 2017 -0400
Committer: Clebert Suconic <[hidden email]>
Committed: Fri Apr 14 18:07:09 2017 -0400

----------------------------------------------------------------------
 .../activemq/artemis/core/journal/impl/JournalTransaction.java  | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3076b84c/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
index 36d585a..241e5a0 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalTransaction.java
@@ -232,7 +232,10 @@ public class JournalTransaction {
    public void commit(final JournalFile file) {
       JournalCompactor compactor = journal.getCompactor();
 
-      // The race lies here....
+      // https://issues.apache.org/jira/browse/ARTEMIS-1114
+      //   There was a race once where compacting was not set
+      //   because the Journal was missing a readLock and compacting was starting
+      //   withut setting this properly...
       if (compacting && compactor != null) {
          if (logger.isTraceEnabled()) {
             logger.trace("adding tx " + this.id + " into compacting");

Loading...