Performance issue in FilePendingMessageCursor.isEmpty()

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Performance issue in FilePendingMessageCursor.isEmpty()

Martin Lichtin
With a test sending 5000 messages to a queue, I see heavy CPU use on the broker side (v 5.12.2).
Using Yourkit it shows that the hot spot methods are



FilePendingMessageCursor.isEmpty() iterates over in-memory messages and therefore (as it is a prioritized queue) uses PrioritizedPendingListIterator which uses OrderedPendingList.getAsList() which turns out to be an expensive method as it converts the self-managed linked list to a Java ArrayList.

I wonder if anyone else has seen this issue?

Perhaps PrioritizedPendingListIterator could be improved to walk the priority lists via OrderedPendingList iterators, as these are implemented efficiently.

- Martin



Reply | Threaded
Open this post in threaded view
|

Re: Performance issue in FilePendingMessageCursor.isEmpty()

Tim Bain
Looks like your attachment from YourKit was stripped off.

But your suggestion seems like a reasonable improvement; submit a JIRA
enhancement request.  Even better, a patch or a pull request!
On Apr 9, 2016 11:51 AM, "Martin Lichtin" <[hidden email]> wrote:

With a test sending 5000 messages to a queue, I see heavy CPU use on the
broker side (v 5.12.2).
Using Yourkit it shows that the hot spot methods are



FilePendingMessageCursor.isEmpty() iterates over in-memory messages and
therefore (as it is a prioritized queue) uses
PrioritizedPendingListIterator which uses OrderedPendingList.getAsList()
which turns out to be an expensive method as it converts the self-managed
linked list to a Java ArrayList.

I wonder if anyone else has seen this issue?

Perhaps PrioritizedPendingListIterator could be improved to walk the
priority lists via OrderedPendingList iterators, as these are implemented
efficiently.

- Martin
Reply | Threaded
Open this post in threaded view
|

Re: Re: Performance issue in FilePendingMessageCursor.isEmpty()

Martin Lichtin
Ok, I submitted a JIRA https://issues.apache.org/jira/browse/AMQ-6239

On 10.04.2016 06:11, Tim Bain wrote:

> Looks like your attachment from YourKit was stripped off.
>
> But your suggestion seems like a reasonable improvement; submit a JIRA
> enhancement request.  Even better, a patch or a pull request!
> On Apr 9, 2016 11:51 AM, "Martin Lichtin" <[hidden email]> wrote:
>
> With a test sending 5000 messages to a queue, I see heavy CPU use on the
> broker side (v 5.12.2).
> Using Yourkit it shows that the hot spot methods are
>
>
>
> FilePendingMessageCursor.isEmpty() iterates over in-memory messages and
> therefore (as it is a prioritized queue) uses
> PrioritizedPendingListIterator which uses OrderedPendingList.getAsList()
> which turns out to be an expensive method as it converts the self-managed
> linked list to a Java ArrayList.
>
> I wonder if anyone else has seen this issue?
>
> Perhaps PrioritizedPendingListIterator could be improved to walk the
> priority lists via OrderedPendingList iterators, as these are implemented
> efficiently.
>
> - Martin
>