NMS API - Add Trace log level to NMS Tracer

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

NMS API - Add Trace log level to NMS Tracer

Krzysztof
Hi,

I would like to extend Tracer API -->
https://github.com/apache/activemq-nms-api/blob/master/src/nms-api/Tracer.cs

with "Trace" log level. Currently there are 5 log levels available (Debug,
Info, Warn, Error, Fatal), but Trace is missing.

Ideally I would like to abandon Tracer concept whatsoever, and replace it
with something more suitable for this day and age, like
Microsoft.Extensions.Logging.Abstractions, which is de facto standard
abstraction for logging concerns in .net world.

What do you think?

Thanks,
Krzysztof
Reply | Threaded
Open this post in threaded view
|

RE: NMS API - Add Trace log level to NMS Tracer

Heiser, Derek
That makes sense to me. Why create code we have to maintain when there's a 1st-party solution?

One other thing that note is that it would also encourage clients to use that interface as well, and give them access to those levels of logs by default if they implement Logging.Abstrations (a practice MS is promoting).

Is there anything in particular that Trace does which a log level wouldn't?

~Derek

-----Original Message-----
From: Krzysztof <[hidden email]>
Sent: Saturday, October 19, 2019 11:56 AM
To: [hidden email]
Subject: NMS API - Add Trace log level to NMS Tracer

[External Email]
------------------------------------------------------------------------------

Hi,

I would like to extend Tracer API -->
https://github.com/apache/activemq-nms-api/blob/master/src/nms-api/Tracer.cs

with "Trace" log level. Currently there are 5 log levels available (Debug, Info, Warn, Error, Fatal), but Trace is missing.

Ideally I would like to abandon Tracer concept whatsoever, and replace it with something more suitable for this day and age, like Microsoft.Extensions.Logging.Abstractions, which is de facto standard abstraction for logging concerns in .net world.

What do you think?

Thanks,
Krzysztof

Follow Us: Facebook<http://www.qg.com/social1> | Twitter<http://www.qg.com/social2> | LinkedIn<http://www.qg.com/social3> | YouTube<http://www.qg.com/social4>
Reply | Threaded
Open this post in threaded view
|

Re: NMS API - Add Trace log level to NMS Tracer

Krzysztof
Nothing particular that I am aware of. I can create a PR with these
changes, but I am not sure if this should be a part of nms 2.0 work (as it
may be considered as a breaking change for some folks), or not?

Thanks,
Krzysztof

On Mon, Oct 21, 2019 at 3:22 PM Heiser, Derek <[hidden email]> wrote:

> That makes sense to me. Why create code we have to maintain when there's a
> 1st-party solution?
>
> One other thing that note is that it would also encourage clients to use
> that interface as well, and give them access to those levels of logs by
> default if they implement Logging.Abstrations (a practice MS is promoting).
>
> Is there anything in particular that Trace does which a log level wouldn't?
>
> ~Derek
>
> -----Original Message-----
> From: Krzysztof <[hidden email]>
> Sent: Saturday, October 19, 2019 11:56 AM
> To: [hidden email]
> Subject: NMS API - Add Trace log level to NMS Tracer
>
> [External Email]
>
> ------------------------------------------------------------------------------
>
> Hi,
>
> I would like to extend Tracer API -->
>
> https://github.com/apache/activemq-nms-api/blob/master/src/nms-api/Tracer.cs
>
> with "Trace" log level. Currently there are 5 log levels available (Debug,
> Info, Warn, Error, Fatal), but Trace is missing.
>
> Ideally I would like to abandon Tracer concept whatsoever, and replace it
> with something more suitable for this day and age, like
> Microsoft.Extensions.Logging.Abstractions, which is de facto standard
> abstraction for logging concerns in .net world.
>
> What do you think?
>
> Thanks,
> Krzysztof
>
> Follow Us: Facebook<http://www.qg.com/social1> | Twitter<
> http://www.qg.com/social2> | LinkedIn<http://www.qg.com/social3> |
> YouTube<http://www.qg.com/social4>
>
Reply | Threaded
Open this post in threaded view
|

Re: NMS API - Add Trace log level to NMS Tracer

michael.andre.pearce
What ever we do we should ensure compatibility even when we add NMS 2.x api. Just as like in JMS when going 1.x to 2.x all old methods and classes were not removed, just simply newer. This ensured no breaking changes to any existing code, or frameworks that had built around.




Get Outlook for Android







On Wed, Oct 23, 2019 at 9:45 AM +0200, "Krzysztof" <[hidden email]> wrote:










Nothing particular that I am aware of. I can create a PR with these
changes, but I am not sure if this should be a part of nms 2.0 work (as it
may be considered as a breaking change for some folks), or not?

Thanks,
Krzysztof

On Mon, Oct 21, 2019 at 3:22 PM Heiser, Derek  wrote:

> That makes sense to me. Why create code we have to maintain when there's a
> 1st-party solution?
>
> One other thing that note is that it would also encourage clients to use
> that interface as well, and give them access to those levels of logs by
> default if they implement Logging.Abstrations (a practice MS is promoting).
>
> Is there anything in particular that Trace does which a log level wouldn't?
>
> ~Derek
>
> -----Original Message-----
> From: Krzysztof
> Sent: Saturday, October 19, 2019 11:56 AM
> To: [hidden email]
> Subject: NMS API - Add Trace log level to NMS Tracer
>
> [External Email]
>
> ------------------------------------------------------------------------------
>
> Hi,
>
> I would like to extend Tracer API -->
>
> https://github.com/apache/activemq-nms-api/blob/master/src/nms-api/Tracer.cs
>
> with "Trace" log level. Currently there are 5 log levels available (Debug,
> Info, Warn, Error, Fatal), but Trace is missing.
>
> Ideally I would like to abandon Tracer concept whatsoever, and replace it
> with something more suitable for this day and age, like
> Microsoft.Extensions.Logging.Abstractions, which is de facto standard
> abstraction for logging concerns in .net world.
>
> What do you think?
>
> Thanks,
> Krzysztof
>
> Follow Us: Facebook | Twitter<
> http://www.qg.com/social2> | LinkedIn |
> YouTube
>