[GitHub] michaelandrepearce commented on issue #2490: V2 196

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] michaelandrepearce commented on issue #2490: V2 196

GitBox
michaelandrepearce commented on issue #2490: V2 196
URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-453079968
 
 
   @gemmellr so this is the same pattern used quite a bit, e.g. if you look at in master: ClusterTopologyChangeMessage_V2 it was used when adding backupGroupName, like wise you will see similar in other XXXMessage.
   
   By the extra bits only being at the end, older servers simply read the old fields out it just doesnt read the extra byte. And having the readableBytes check means if the reverse where an older client wont have provided the extra bytes, then this is where we default it.
   
   There is also a bunch on compatibility tests that @clebertsuconic made, that if there was a compatibility break it would be picked up.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services