[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

GitBox
michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management
URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247781204
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
 ##########
 @@ -1005,9 +1006,9 @@ public RemotingConnection getRemotingConnection() {
          ByteBuffer buffer = ByteBuffer.allocate(8);
          buffer.putLong(queue.getID());
          message.putBytesProperty(Message.HDR_ROUTE_TO_IDS, buffer.array());
-         postOffice.route(message, true);
+         server.getPostOffice().route(LargeServerMessageImpl.checkLargeMessage(message, server.getStorageManager()), true);
 
 Review comment:
   Maybe rather than directly routing to the post office, should we not send via serversession? This would then sort the large message issue but also ensure the message is treated like others so in future if other bits should happen we dont risk having two ways. Noted already that  not going via serversession i see we miss the broker plugin.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services