[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...

wy96f
GitHub user RagnarPaulson opened a pull request:

    https://github.com/apache/activemq-nms-amqp/pull/1

    AMQNET-576: Clean out old code base for NMS AMQP client provider.

    The first step to replacing the NMS AMQP client with a fully managed client based on AMQPNetLite is to remove the old implementation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RagnarPaulson/activemq-nms-amqp master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-nms-amqp/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
   
----
commit 303fcf360c3bf10c186108638ceb9b391b7e34a5
Author: Ragnar Paulson <ragnar.paulson@...>
Date:   2018-05-22T18:40:31Z

    AMQNET-576: Clean out old code base for NMS AMQP client provider.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...

wy96f
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-nms-amqp/pull/1
 
    The move of legacy code was done properly now on the Apache repo, this PR needs to be rebased and squashed into one commit for review.  


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...

wy96f
In reply to this post by wy96f
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-nms-amqp/pull/1
 
    This looks like it could be closed now given a new PR(#2) with the client code is now open


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-nms-amqp pull request #1: AMQNET-576: Clean out old code base for N...

wy96f
In reply to this post by wy96f
Github user RagnarPaulson closed the pull request at:

    https://github.com/apache/activemq-nms-amqp/pull/1


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-nms-amqp issue #1: AMQNET-576: Clean out old code base for NMS AMQP...

wy96f
In reply to this post by wy96f
Github user RagnarPaulson commented on the issue:

    https://github.com/apache/activemq-nms-amqp/pull/1
 
    Per the last comment, and because the old repository is gone and a new one ready to replace it, I'm closing this pull request.


---