[GitHub] activemq-cpp pull request #8: Update PlatformThread.cpp

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-cpp pull request #8: Update PlatformThread.cpp

rstancel
GitHub user amg077-motorolasolutions-com opened a pull request:

    https://github.com/apache/activemq-cpp/pull/8

    Update PlatformThread.cpp

    Added handling thread creation failure when  _beginthreadex() returns (uintptr_t )-1L. See MSDN:
    https://msdn.microsoft.com/en-us/library/kdzttdcb.aspx
    for details.
    Added errno and _doserrno to exception message.
    Reason:
    PlatformThread::createNewThread() is a public method. Developer who uses this method expects, that it is enough to catch an exception and next apply usual null pointer checking. Value -1L is different than NULL so it would cause memory access violation on de-reference.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amg077-motorolasolutions-com/activemq-cpp master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-cpp/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
   
----
commit 9a05fa756390bd3bcddc19d2ee242078dcde5938
Author: amg077-motorolasolutions-com <45261601+amg077-motorolasolutions-com@...>
Date:   2018-11-26T08:59:06Z

    Update PlatformThread.cpp
   
    Added handling thread creation failure when  _beginthreadex() returns (uintptr_t )-1L. See MSDN:
    https://msdn.microsoft.com/en-us/library/kdzttdcb.aspx
    for details.
    Added errno and _doserrno to exception message.
    Reason:
    PlatformThread::createNewThread() is a public method. Developer who uses this method expects, that it is enough to catch an exception and next apply usual null pointer checking. Value -1L is different than NULL so it would cause memory access violation on de-reference.

commit a8eeadb1a61b1880653cf755799590c9e615da80
Author: amg077-motorolasolutions-com <45261601+amg077-motorolasolutions-com@...>
Date:   2018-11-26T09:35:36Z

    Merge pull request #1 from amg077-motorolasolutions-com/amg077-motorolasolutions-com-patch-1
   
    Update PlatformThread.cpp

----


---