[GitHub] activemq-artemis pull request: Executor in JournalImpl for append operations

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request: Executor in JournalImpl for append operations

asfgit
GitHub user barreiro opened a pull request:

    https://github.com/apache/activemq-artemis/pull/548

    Executor in JournalImpl for append operations

    This new executor on the journal allows the removal of synchronization in most cases. It can enable other optimizations in the future as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/barreiro/activemq-artemis append-executor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #548
   
----
commit ed7c709f49a5e648226e87255ba8583db7445e0d
Author: barreiro <[hidden email]>
Date:   2016-01-22T03:23:26Z

    Add executor service to JournalImpl for append operations and remove synchronization

commit 0aa89ee8fd8598f0ec04733d52ddb3dda1850ebe
Author: barreiro <[hidden email]>
Date:   2016-04-22T02:49:59Z

    Fix DecodeJournal

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    lets defer merging this until the release is done.
   
    quite a big change now at the last minute.. better to wait next release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @clebertsuconic I think we can start looking at this now that we have 1.3.0 out the door.  Are you able review?  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @mtaylor  I want to compare this against #590. Especially on a test that is being added.
   
    Franceso proposed a garbage free approach on the journal that makes sense.. and I want to make sure this wouldn't make it inviable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @clebertsuconic NP just checking we haven't forgot about this.  Cheers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @clebertsuconic Any update on this?  Did you manage to complete the comparison you wanted to do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @mtaylor there's a test failure I need to take care before can merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @barreiro did you think of using an executor from the ThreadPool? (ExecutorFactory.createExecutor()) from ActiveMQServerImpl?
   
    What about using the same executor for the bindings and journal? this is creating a single thread for each journal even at low rates.
   
   
    The issue with the tests is because of the lack of flushing the executor for certain non transactional tests. (ValidateTransactionalHealth being one).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @barreiro  sorry it took me this long to get into this.. but lets close this one soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    The failures on Paging is because the system currently doubles the size of the buffer, because the address name is not encoded as part of every message, while it is encoded during journal.append. Something I will have to address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    This will need a JIRA and a squash of the commit here as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user barreiro commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    Rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @barreiro just a FYI: I'm working on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @barreiro I wil need a JIRA, can you raise one on Artemis


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    @barreiro can you close this one please, #872 will replace this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

asfgit
In reply to this post by asfgit
Github user barreiro commented on the issue:

    https://github.com/apache/activemq-artemis/pull/548
 
    Superseded by #872  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #548: Executor in JournalImpl for append opera...

asfgit
In reply to this post by asfgit
Github user barreiro closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/548


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---