[GitHub] activemq-artemis pull request #983: ARTEMIS-936 - make amqp transformers con...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #983: ARTEMIS-936 - make amqp transformers con...

franz1981
GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/983

    ARTEMIS-936 - make amqp transformers configurable and default to native

    https://issues.apache.org/jira/browse/ARTEMIS-936

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/983.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #983
   
----
commit ff1f28a9214b5ec794c4a9536c07193608830aa0
Author: Andy Taylor <[hidden email]>
Date:   2017-02-01T12:09:07Z

    ARTEMIS-936 - make amqp transformers configurable and default to native
   
    https://issues.apache.org/jira/browse/ARTEMIS-936

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    @andytaylor these failures on the PR check seem real.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user gemmellr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    The new documentation seems a little confusing given all the mentions of JMS, which is often only indirectly related to what the transformers are doing, with cross-protocol conversion really being what is affected. Folks not using JMS clients are also going to be affected by transformer changes, and folks using AMQP JMS clients wont be affected in the way the documentation might seem to suggest (e.g they wont suddenly receive a BytesMessage just because the broker used one internally in its native transformer to carry the AMQP bytes of a TextMessage they had sent to the broker).
   
    The example of configuring a 'jms' transformer actually gives configuration for a 'native' one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    I took this documentation from ActiveMQ and its only really related to the JMS client, we could probably add more details about other cross protocol transformations, MQTT for instance.  you are correct folks just using AMQP won't be effected but if they use AMQP to JMS they will.
   
    I'll fix the example


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    example fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    actually leave this PR for now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    Any news on this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    @jbertram this will probably be closed without merging... it won't be needed with what I'm doing...
   
   
    AMQP Messages are always raw on my branch.. they only get converted when crossing protocols.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #983: ARTEMIS-936 - make amqp transformers configurab...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/983
 
    @andytaylor native converters are gone on my branch. We will not require conversions any more... can you close this one? it's moot now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #983: ARTEMIS-936 - make amqp transformers con...

franz1981
In reply to this post by franz1981
Github user andytaylor closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/983


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---