[GitHub] activemq-artemis pull request #964: https://issues.apache.org/jira/browse/AR...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #964: https://issues.apache.org/jira/browse/AR...

tabish121-2
GitHub user dejanb opened a pull request:

    https://github.com/apache/activemq-artemis/pull/964

    https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard …

    …address configuration in mqtt layer
   
    https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dejanb/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #964
   
----
commit 79e695872d713089d79c93297d5d72545f3bba5a
Author: Dejan Bosanac <[hidden email]>
Date:   2017-01-17T14:44:28Z

    https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer
   
    https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...

tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/964
 
    A test would be nice



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/964
 
    @dejanb  I am confused.. is this new functionality, or this is just a refactoring of an existing one (on which case you wouldn't need tests).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...

tabish121-2
In reply to this post by tabish121-2
Github user dejanb commented on the issue:

    https://github.com/apache/activemq-artemis/pull/964
 
    @clebertsuconic It's not a new functionality, it's just adjusting mqtt layer code, which used hard-coded wildcard characters. I'll add a test to verify wildcard syntax of ActiveMQ 5, works fine and that we can exchange messages between mqtt and JMS clients. That should help with future migrations


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/964
 
    @dejanb, where are you on the test effort?
   
    Also, can you amend your commit message to follow the 50/72 format discussed in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#commitMessageDetails)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/964
 
    Looks like you may need to rebase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...

tabish121-2
In reply to this post by tabish121-2
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/964
 
    @dejanb I've rebased and pushed another PR (so we get the PR checks) at #1021.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...

tabish121-2
In reply to this post by tabish121-2
Github user dejanb commented on the issue:

    https://github.com/apache/activemq-artemis/pull/964
 
    Great. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #964: https://issues.apache.org/jira/browse/AR...

tabish121-2
In reply to this post by tabish121-2
Github user dejanb closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/964


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---