Quantcast

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

asfgit
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/956

    ARTEMIS-915 WebComponent stopped when backup failback

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master-915

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #956
   
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/956#discussion_r95607988
 
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ShutdownAwareComponent.java ---
    @@ -0,0 +1,28 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.core.server;
    +
    +/**
    + * A Component that needs to know the stop reason.
    + */
    +public interface ShutdownAwareComponent extends ActiveMQComponent {
    --- End diff --
   
    I really don't like that name...
   
    What about calling it ServiceComponent
   
    make the method to be called stop(boolean isShutdown)
   
   
    No need for these integers, and in case you want to keep a parameter, please use an enumeration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/956#discussion_r95608200
 
    --- Diff: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java ---
    @@ -170,4 +173,15 @@ private WebAppContext deployWar(String url, String warFile, Path warDirectory) t
           handlers.addHandler(webapp);
           return webapp;
        }
    +
    +   @Override
    +   public void stop() throws Exception {
    --- End diff --
   
    please, just for completeness.. call stop(true); here (after the method name change I asked you)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/956#discussion_r95716694
 
    --- Diff: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java ---
    @@ -170,4 +173,15 @@ private WebAppContext deployWar(String url, String warFile, Path warDirectory) t
           handlers.addHandler(webapp);
           return webapp;
        }
    +
    +   @Override
    +   public void stop() throws Exception {
    --- End diff --
   
    @clebertsuconic Done. Just let you know I called stop(false) in order to prevent it from stopping. (true means to really stop). Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/956#discussion_r95716829
 
    --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ShutdownAwareComponent.java ---
    @@ -0,0 +1,28 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.core.server;
    +
    +/**
    + * A Component that needs to know the stop reason.
    + */
    +public interface ShutdownAwareComponent extends ActiveMQComponent {
    --- End diff --
   
    yeah, the name is stupid. but believe me I've been thinking it for a long time and finally came up with a name which is stupid. :) ServiceComponent is much better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/956#discussion_r95721658
 
    --- Diff: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java ---
    @@ -170,4 +173,15 @@ private WebAppContext deployWar(String url, String warFile, Path warDirectory) t
           handlers.addHandler(webapp);
           return webapp;
        }
    +
    +   @Override
    +   public void stop() throws Exception {
    --- End diff --
   
    @gaohoward if someone called stop() directly, I would expect it to really shutdown.
   
    But I guess it's ok this way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #956: ARTEMIS-915 WebComponent stopped when ba...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/956


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...