[GitHub] activemq-artemis pull request #955: ARTEMIS-562 Use 'to' field if sender tar...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #955: ARTEMIS-562 Use 'to' field if sender tar...

franz1981
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/955

    ARTEMIS-562 Use 'to' field if sender target is null

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master_562

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #955
   
----
commit e2a1a4dbb780b82810d6b9f116c9f6a7b4d2c810
Author: Howard Gao <[hidden email]>
Date:   2017-01-10T12:51:42Z

    ARTEMIS-562 Use 'to' field if sender target is null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #955: ARTEMIS-562 Use 'to' field if sender target is ...

franz1981
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/955
 
    Based on Time's patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #955: ARTEMIS-562 Use 'to' field if sender tar...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/955#discussion_r95383350
 
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java ---
    @@ -429,6 +442,12 @@ public void offerProducerCredit(final String address,
                                        final int threshold,
                                        final Receiver receiver) {
           try {
    +         // TODO - Do something smart here with the paging bits to figure out the credit can be sent.
    --- End diff --
   
    I don't think there's anything to be done with paging. If this is an anonymous producer, there's nothing to be done with paging...
   
    Either this is the proper implementation, hence you would need to remove the TODO, or this is something else broken.
   
    I believe you should just remove the TODO here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #955: ARTEMIS-562 Use 'to' field if sender tar...

franz1981
In reply to this post by franz1981
Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/955#discussion_r95488980
 
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java ---
    @@ -429,6 +442,12 @@ public void offerProducerCredit(final String address,
                                        final int threshold,
                                        final Receiver receiver) {
           try {
    +         // TODO - Do something smart here with the paging bits to figure out the credit can be sent.
    --- End diff --
   
    Thanks clebert. I'll remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #955: ARTEMIS-562 Use 'to' field if sender target is ...

franz1981
In reply to this post by franz1981
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/955
 
    Just checked the failure not related to this PR, and it's probably not a real issue. Pass always on local.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #955: ARTEMIS-562 Use 'to' field if sender tar...

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/955


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...