Quantcast

[GitHub] activemq-artemis pull request #949: ARTEMIS-910 Broker does not start if pat...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #949: ARTEMIS-910 Broker does not start if pat...

asfgit
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/949

    ARTEMIS-910 Broker does not start if path contains spaces

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master_artemis910

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #949
   
----
commit 96c237749fda04eee44c16c1d2e6d17cf0be7e15
Author: Howard Gao <[hidden email]>
Date:   2017-01-06T08:22:40Z

    ARTEMIS-910 Broker does not start if path contains spaces

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #949: ARTEMIS-910 Broker does not start if pat...

asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/949#discussion_r95068909
 
    --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis.cmd ---
    @@ -58,9 +58,9 @@ call %ARTEMIS_INSTANCE%\etc\artemis.profile.cmd %*
     rem "Create full JVM Args"
     set JVM_ARGS=%JAVA_ARGS%
     if not "%ARTEMIS_CLUSTER_PROPS%"=="" set JVM_ARGS=%JVM_ARGS% %ARTEMIS_CLUSTER_PROPS%
    -set JVM_ARGS=%JVM_ARGS% -classpath %ARTEMIS_HOME%\lib\artemis-boot.jar
    -set JVM_ARGS=%JVM_ARGS% -Dartemis.home=%ARTEMIS_HOME%
    -set JVM_ARGS=%JVM_ARGS% -Dartemis.instance=%ARTEMIS_INSTANCE%
    +set JVM_ARGS=%JVM_ARGS% -classpath "%ARTEMIS_HOME%\lib\artemis-boot.jar"
    --- End diff --
   
    did you actually test it on windows?
   
   
    I over tested this on both linux, windows... there's a test under ./scripts validating it.. what is not working?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #949: ARTEMIS-910 Broker does not start if path conta...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/949
 
    guys..please let me talk to howard before merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #949: ARTEMIS-910 Broker does not start if path conta...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/949
 
    @gaohoward @howardgao lets talk on monday... this is actually breaking things... the current version is actually working, and stopped working after your commit here. look at ./artemis-distribution/src/test/scripts/validate-spaces.sh (Just run the script)...
   
    it works without your fix, and it fails with it.
   
   
    Please, don't merge it.. I'm not sure what is the issue you found.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #949: ARTEMIS-910 Broker does not start if path conta...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/949
 
    Hi Clebert,
   
    Sorry I didn't notice there is such a script. I just run the script and it passes on my machine (It doesn't give the final result but I can see it runs some tests and gracefully shutdown).
   
    Regarding the testing, I actually tested on 2 platforms:
   
    Ubuntu 16.04 LTS (64bit)
    Windows 10 64bit (I didn't test cygwin thou).
   
    I can confirm both platform works with my fix, but fails without.
   
    Howard
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #949: ARTEMIS-910 Broker does not start if path conta...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/949
 
    @gaohoward I couldn't make it to fail, can you tell me how to replicate the issue?
   
    In special I am looking to do it through the script test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #949: ARTEMIS-910 Broker does not start if path conta...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/949
 
    Hi Clebert,
   
    It's strange that I couldn't make it either when I tried just now. I also test on windows it doesn't fail any more. I don't know why, maybe I messed up my environment.
    Maybe we should just close this, it's a false alarm I guess.
   
    Howard



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #949: ARTEMIS-910 Broker does not start if path conta...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/949
 
    Confirmed with @clebertsuconic, not an issue. Close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #949: ARTEMIS-910 Broker does not start if pat...

asfgit
In reply to this post by asfgit
Github user gaohoward closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/949


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...