[GitHub] activemq-artemis pull request #780: Removed unused JMS class and Test from a...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #780: Removed unused JMS class and Test from a...

asfgit
GitHub user bennetelli opened a pull request:

    https://github.com/apache/activemq-artemis/pull/780

    Removed unused JMS class and Test from artemis-rest

    The JMS class in the artemis-rest project seems to be unused.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bennetelli/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #780
   
----
commit f18d07407d2e4f4cfb78475a665407c12691a170
Author: Bennet Schulz <[hidden email]>
Date:   2016-08-11T18:45:46Z

    ARTEMIS-680 some refactorings within Vert.X integration and corresponding tests

commit 8ff6b2e340e7f0ed8c09b2d7d9c4b7728f961563
Author: Bennet Schulz <[hidden email]>
Date:   2016-09-07T15:39:47Z

    Merge pull request #1 from apache/master
   
    updating my fork

commit a6c44462666889c87ed6f336019d06915d65dfc1
Author: Bennet Schulz <[hidden email]>
Date:   2016-09-16T12:14:44Z

    refactored tests, renamed some classes and refactored classes and methods to be more modular

commit b45dfa4e61345bf084dbea810f6cafe55047b2fd
Author: Bennet Schulz <[hidden email]>
Date:   2016-09-16T18:02:00Z

    Merge remote-tracking branch 'upstream/master'

commit 1ce6e8cd2e6154b92149739b7056664e66c2d022
Author: Bennet Schulz <[hidden email]>
Date:   2016-09-16T18:07:57Z

    removed unused JMS class and Test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: Removed unused JMS class and Test from artemis-...

asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    can you do the following commands:
   
   
    ```sh
    git remote add upstream https://github.com/apache/activemq-artemis.git
    git pull --rebase upstream master
    git push origin -f
    ```
   
   
    you should also mention the JIRA you created for refactoring on rest.
   
   
    There are a couple of reviews I want to comment, but these merges you have here are reallly messed up, if you do the commands I asked these will get fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    You should make JIRA to be part of the commits... the PR name will get lost once merged.
   
    do this:
   
   
    git rebase -i HEAD~2
   
   
   
    edit the name of these two commits and include the jira.
   
   
   
    git push origin -f
   
   
   
    (I don't mean to be teaching you git.. if you know these commands it's just a way to communicate, easier in git than english :) )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    I see what you did, you changed the title of the PR. you have to change the title of the committs.. look at my previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user bennetelli commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    typically I don't do those things with git. Squashing commits and working with github pull request is new to me as well. Will do it better in future. I promise ;) Thanks for your help :-) Will fix it the next days.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    Any update on this PR?  It not only needs to be squashed, but the commit message needs to be amended to follow the 50/72 pattern discussed in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user bennetelli commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    will take a look at this pr at thursday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    I fixed it myself with some git-fu while I merged it (amends and stuff)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #780: ARTEMIS-735 Refactoring of JUnit Tests i...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/780


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    I did this now since I'm about to make a release and wanted to finish most of what I could.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

asfgit
In reply to this post by asfgit
Github user bennetelli commented on the issue:

    https://github.com/apache/activemq-artemis/pull/780
 
    thanks clebert.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---