[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/754

    Adding my releasing experience to RELEASING.md

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis release-notes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/754.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #754
   
----
commit d528d608c1e7bffe91a15bca08ad3c8fde9e0966
Author: Clebert Suconic <[hidden email]>
Date:   2016-09-06T21:04:30Z

    Adding my releasing experience to RELEASING.md

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77720730
 
    --- Diff: RELEASING.md ---
    @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/
     Remove these files manually under Nexus while the repository is still open.
     
     
    +## Checking out a new empty git repository
    +
    +Before starting make sure you clone a brand new empty the git repository as follows as the release plugin will use the upstream for pushing the tags:
    +
    +```sh
    +git clone git://github.com/apache/activemq-artemis.git
    +cd activemq-artemis
    +git remote add upstream https://git-wip-us.apache.org/repos/asf/activemq-artemis.git
    --- End diff --
   
    Maybe set `pushChanges` to false? http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#pushChanges


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77720861
 
    --- Diff: RELEASING.md ---
    @@ -45,6 +55,26 @@ mvn clean release:prepare -DautoVersionSubmodules=true -Prelease
     ```
     
     
    +To upload it, perform this command:
    +
    +```sh
    +mvn release:perform -Prelease
    +```
    +
    +
    +### Resuming release upload
    +
    +If something happened during the release upload you may need to eventually redo the upload.
    +
    +There is a release.properties file that is generated during the release. In case you want to upload a previously tagged release, add this file as follows:
    +
    +- release.properties
    +```
    +scm.url=scm:git:https://github.com/apache/activemq-artemis.git
    --- End diff --
   
    Thats a read only mirror... how can we push to that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #754: Adding my releasing experience to RELEASING.md

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/754
 
    github is not letting me answer online now.. or even Tag.
   
    So, for the release.properties... after the release is prepared... release:perform will checkout the TAG and do from scratch. This is supposed to be read-only. We could specify the apache repo, but not really needed.. this is just if something gets screwed during the upload.
   
   
    pushChanges to false? We haven't used that... but it could be a nice trick. how it works? it just sets the committs locally? and you have to push yourself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #754: Adding my releasing experience to RELEASING.md

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/754
 
    github is not letting me answer online now.. or even Tag.
   
    So, for the release.properties... after the release is prepared... release:perform will checkout the TAG and do from scratch. This is supposed to be read-only. We could specify the apache repo, but not really needed.. this is just if something gets screwed during the upload.
   
   
    pushChanges to false? I haven't used that... but it could be a nice trick. how it works? it just sets the committs locally? and you have to push yourself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #754: Adding my releasing experience to RELEASING.md

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/754
 
    github is not letting me answer online now.. or even Tag.
   
    So, for the release.properties... after the release is prepared... release:perform will checkout the TAG and do from scratch. This is supposed to be read-only. We could specify the apache repo, but not really needed.. this is just if something gets screwed during the upload.
   
   
    pushChanges to false? I haven't used that... but it could be a nice trick. how it works? it just sets the committs locally? and you have to push yourself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77723708
 
    --- Diff: RELEASING.md ---
    @@ -45,6 +55,26 @@ mvn clean release:prepare -DautoVersionSubmodules=true -Prelease
     ```
     
     
    +To upload it, perform this command:
    +
    +```sh
    +mvn release:perform -Prelease
    +```
    +
    +
    +### Resuming release upload
    +
    +If something happened during the release upload you may need to eventually redo the upload.
    +
    +There is a release.properties file that is generated during the release. In case you want to upload a previously tagged release, add this file as follows:
    +
    +- release.properties
    +```
    +scm.url=scm:git:https://github.com/apache/activemq-artemis.git
    --- End diff --
   
    So, for the release.properties... after the release is prepared... release:perform will checkout the TAG and do from scratch. This is supposed to be read-only. We could specify the apache repo, but not really needed.. this is just if something gets screwed during the upload.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77723815
 
    --- Diff: RELEASING.md ---
    @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/
     Remove these files manually under Nexus while the repository is still open.
     
     
    +## Checking out a new empty git repository
    +
    +Before starting make sure you clone a brand new empty the git repository as follows as the release plugin will use the upstream for pushing the tags:
    +
    +```sh
    +git clone git://github.com/apache/activemq-artemis.git
    +cd activemq-artemis
    +git remote add upstream https://git-wip-us.apache.org/repos/asf/activemq-artemis.git
    --- End diff --
   
    @johnament  I have never used that... it seems a nice trick.
   
    It just sets the commits locally?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77727254
 
    --- Diff: RELEASING.md ---
    @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/
     Remove these files manually under Nexus while the repository is still open.
     
     
    +## Checking out a new empty git repository
    +
    +Before starting make sure you clone a brand new empty the git repository as follows as the release plugin will use the upstream for pushing the tags:
    +
    +```sh
    +git clone git://github.com/apache/activemq-artemis.git
    +cd activemq-artemis
    +git remote add upstream https://git-wip-us.apache.org/repos/asf/activemq-artemis.git
    --- End diff --
   
    Yep, then you can push wherever you want.  Usually we only push tags after the release is fully executed.  So its ok if its sitting out on your mirror.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77727346
 
    --- Diff: RELEASING.md ---
    @@ -45,6 +55,26 @@ mvn clean release:prepare -DautoVersionSubmodules=true -Prelease
     ```
     
     
    +To upload it, perform this command:
    +
    +```sh
    +mvn release:perform -Prelease
    +```
    +
    +
    +### Resuming release upload
    +
    +If something happened during the release upload you may need to eventually redo the upload.
    +
    +There is a release.properties file that is generated during the release. In case you want to upload a previously tagged release, add this file as follows:
    +
    +- release.properties
    +```
    +scm.url=scm:git:https://github.com/apache/activemq-artemis.git
    --- End diff --
   
    Ah.  I misread what you meant by release upload... you're talking about the upload to nexus.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77732653
 
    --- Diff: RELEASING.md ---
    @@ -45,6 +55,26 @@ mvn clean release:prepare -DautoVersionSubmodules=true -Prelease
     ```
     
     
    +To upload it, perform this command:
    +
    +```sh
    +mvn release:perform -Prelease
    +```
    +
    +
    +### Resuming release upload
    +
    +If something happened during the release upload you may need to eventually redo the upload.
    +
    +There is a release.properties file that is generated during the release. In case you want to upload a previously tagged release, add this file as follows:
    +
    +- release.properties
    +```
    +scm.url=scm:git:https://github.com/apache/activemq-artemis.git
    --- End diff --
   
    I will ammend with the word nexus to make sure it's clearer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77816394
 
    --- Diff: RELEASING.md ---
    @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/
     Remove these files manually under Nexus while the repository is still open.
     
     
    +## Checking out a new empty git repository
    +
    +Before starting make sure you clone a brand new empty the git repository as follows as the release plugin will use the upstream for pushing the tags:
    +
    +```sh
    +git clone git://github.com/apache/activemq-artemis.git
    +cd activemq-artemis
    +git remote add upstream https://git-wip-us.apache.org/repos/asf/activemq-artemis.git
    --- End diff --
   
    @johnament how do you use this? from what I looked I would need to change the pom for that. Can I use -D variables somehow?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/754#discussion_r77832397
 
    --- Diff: RELEASING.md ---
    @@ -36,6 +36,16 @@ The file will be located under ./artemis-pom/RELEASE/
     Remove these files manually under Nexus while the repository is still open.
     
     
    +## Checking out a new empty git repository
    +
    +Before starting make sure you clone a brand new empty the git repository as follows as the release plugin will use the upstream for pushing the tags:
    +
    +```sh
    +git clone git://github.com/apache/activemq-artemis.git
    +cd activemq-artemis
    +git remote add upstream https://git-wip-us.apache.org/repos/asf/activemq-artemis.git
    --- End diff --
   
    (added a note for that).
   
   
    Should be ready to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #754: Adding my releasing experience to RELEAS...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/754


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---