[GitHub] activemq-artemis pull request #746: ARTEMIS-657 Fixing JORAM AMQP Tests

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/746

    ARTEMIS-657 Fixing JORAM AMQP Tests

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis joram-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #746
   
----
commit 883cbd16d785410bb5bbd51e9974ae775a7b025e
Author: Clebert Suconic <[hidden email]>
Date:   2016-08-31T16:25:02Z

    ARTEMIS-657 Fixing JORAM AMQP Tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
Github user grs commented on the issue:

    https://github.com/apache/activemq-artemis/pull/746
 
    My apologies for breaking this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/746
 
    @grs no worries.  Dev is about that :)
   
    I just wanted to check if you agree with this Change I made. Or if you know a better fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
In reply to this post by asfgit
Github user grs commented on the issue:

    https://github.com/apache/activemq-artemis/pull/746
 
    To be perfectly honest, I don't really understand the change. (Or why it caused other tests to fail, since prior to my change the body would have simply not been encoded at all).
   
    I get the bit that catches the exception through, which may be what fixes the test? What is the reader index stuff for?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/746
 
    @grs some tests from JORAM are apparently sending empty bodies.. what caused the issue.
   
    I need to only perform this conversion on management operations which is what you wanted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
In reply to this post by asfgit
Github user grs commented on the issue:

    https://github.com/apache/activemq-artemis/pull/746
 
    Ok, I think I understand now. You are only attempting the conversion if the source message does not have the property set and additionally are catching any failure to read the body buffer as a string and resetting the buffer after any read attempt. That all makes sense to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/746
 
    It still failing though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/746
 
    I had one wrong change on provider.properties.... rebased / pusehd -f... next build should have a fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #746: ARTEMIS-657 Fixing JORAM AMQP Tests

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/746


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---