[GitHub] activemq-artemis pull request #733: ARTEMIS-698 Remove full path + executabi...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #733: ARTEMIS-698 Remove full path + executabi...

tabish121-2
GitHub user scop opened a pull request:

    https://github.com/apache/activemq-artemis/pull/733

    ARTEMIS-698 Remove full path + executability check of java

    Fixes issues with systems that have no "which", as well as the fallback
    to using plain "java" from PATH.
   
    This is an alternative fix to #732, see discussion in it for more details.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scop/activemq-artemis no-x-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/733.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #733
   
----
commit 363fc652bf7a468b4f1fd067af3653c6729e4772
Author: Ville Skyttä <[hidden email]>
Date:   2016-08-25T07:05:15Z

    ARTEMIS-698 Remove full path + executability check of java
   
    Fixes issues with systems that have no "which", as well as the fallback
    to using plain "java" from PATH.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #733: ARTEMIS-698 Remove full path + executability ch...

tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/733
 
    @scop  I think you should close this PR, and squash this commit into #732
   
    if you squash it and push -f the PR will be updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #733: ARTEMIS-698 Remove full path + executability ch...

tabish121-2
In reply to this post by tabish121-2
Github user scop commented on the issue:

    https://github.com/apache/activemq-artemis/pull/733
 
    Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #733: ARTEMIS-698 Remove full path + executabi...

tabish121-2
In reply to this post by tabish121-2
Github user scop closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/733


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---