[GitHub] activemq-artemis pull request #732: Try to cope with systems without "which"...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #732: Try to cope with systems without "which"...

tabish121-2
GitHub user scop opened a pull request:

    https://github.com/apache/activemq-artemis/pull/732

    Try to cope with systems without "which" for finding java

    whence -p should work with zsh, type -p with bash and ksh.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scop/activemq-artemis nowhich

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #732
   
----
commit 697536b026fc9718b46ff95b49e54ee9a2c35f4a
Author: Ville Skyttä <[hidden email]>
Date:   2016-08-24T19:06:33Z

    Try to cope with systems without "which" for finding java
   
    whence -p should work with zsh, type -p with bash and ksh.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #732: Try to cope with systems without "which" for fi...

tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/732
 
    How to test this? just remove JAVA_HOME as a property?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #732: Try to cope with systems without "which" for fi...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/732
 
    this one warrants a JIRA I think. Can you add a JIRA, set it to 1.5.0 (I will move it back to 1.4.0). And set the JIRA-id as part of the commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #732: Try to cope with systems without "which" for fi...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/732
 
    @scop what's the best to way to test this? remove JAVA_HOME? I couldn't have much success.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #732: Try to cope with systems without "which" for fi...

tabish121-2
In reply to this post by tabish121-2
Github user scop commented on the issue:

    https://github.com/apache/activemq-artemis/pull/732
 
    Ensure `JAVACMD` and `JAVA_HOME` are not set and `which` is not installed, that should do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #732: Try to cope with systems without "which" for fi...

tabish121-2
In reply to this post by tabish121-2
Github user scop commented on the issue:

    https://github.com/apache/activemq-artemis/pull/732
 
    @clebertsuconic also, in my opinion the separate try to get a full path to the java executable and the related -x test is somewhat questionable. The full path is not actually needed for anything, artemis would work just fine when invoked with java from PATH, without a full path to it. And the JAVACMD=java fallback will pretty much never work with the test. I think it would actually make sense to remove those checks and just try to use java directly. The Windows cmd scripts already do that. I've submitted this alternative approach in #733


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #732: Try to cope with systems without "which"...

tabish121-2
In reply to this post by tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/732


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---