[GitHub] activemq-artemis pull request #2465: ARTEMIS-2130 - This is to allow views t...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2465: ARTEMIS-2130 - This is to allow views t...

asfgit
GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2465

    ARTEMIS-2130 - This is to allow views to have the client id when set …

    …on core protocol
   
    https://issues.apache.org/jira/browse/ARTEMIS-2130

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2465
   
----
commit 433032eab8729ad12c3120d06d102fda095b4b85
Author: andytaylor <andy.tayls67@...>
Date:   2018-12-14T11:54:10Z

    ARTEMIS-2130 - This is to allow views to have the client id when set on core protocol
   
    https://issues.apache.org/jira/browse/ARTEMIS-2130

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

asfgit
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2465
 
    when the core protocol is used the client is not available in the connection, via jmx or console, because it is set on the connecting session. This adds this info at the view level. I couldnt find a better way to do this


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2465
 
    Could there just be a column where we dump all the session metadata?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

asfgit
In reply to this post by asfgit
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2465
 
    The thing is we have a place for client id, the other protocols use this


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2465: ARTEMIS-2130 - This is to allow views to have ...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2465
 
    This does appear to be the simplest solution to a complex issue. Could you use the `org.apache.activemq.artemis.jms.client.ActiveMQConnection#JMS_SESSION_CLIENT_ID_PROPERTY` constant instead of straight "jms-client-id"? You'll need to add a new dependency on the `artemis-server` pom.xml for `artemis-jms-client`.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2465: ARTEMIS-2130 - This is to allow views t...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2465


---