[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...

clebertsuconic-3
GitHub user jdanekrh opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2441

    Assorted Error Prone-related NO-JIRA fixes to tests

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/activemq-artemis jd_errorprone

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2441
   
----
commit 0e7446d6f9354ae74b753996f4607a51f2efaa24
Author: Jiri Danek <jdanek@...>
Date:   2018-11-22T21:52:45Z

    NO-JIRA Fix errorprone error (duplicated expression in condition)

commit c1dbc1b54bd4e044a529f773121f7ab4aaa36eb0
Author: Jiri Danek <jdanek@...>
Date:   2018-07-14T21:52:02Z

    NO-JIRA Add forgotten @Test annotation and make helper methods private

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...

clebertsuconic-3
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2441#discussion_r237521038
 
    --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java ---
    @@ -2231,14 +2232,14 @@ private boolean isEquals(Section left, Section right) {
              byte[] leftArray = leftValue.getValue().getArray();
              byte[] rightArray = rightValue.getValue().getArray();
     
    -         if (leftArray == null && leftArray == null) {
    +         if (leftArray == null && rightArray == null) {
    --- End diff --
   
    @tabish121 I figure this is what you've meant to say here (error prone screams if there are duplicated subexpressions in ifs, like this)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2441


---