[GitHub] activemq-artemis pull request #2439: ARTEMIS-2179 mgmnt method to get cluste...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2439: ARTEMIS-2179 mgmnt method to get cluste...

rstancel
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2439

    ARTEMIS-2179 mgmnt method to get cluster-cxn names

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2179

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2439
   
----
commit 355f4fadeb477fece8ddb3d062a7c914b132a669
Author: Justin Bertram <jbertram@...>
Date:   2018-11-21T00:53:01Z

    ARTEMIS-2179 mgmnt method to get cluster-cxn names

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2439: ARTEMIS-2179 mgmnt method to get cluste...

rstancel
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2439#discussion_r235525451
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java ---
    @@ -950,6 +950,24 @@ public String updateQueue(String name,
           }
        }
     
    +   @Override
    +   public String[] getClusterConnectionNames() {
    +      checkStarted();
    +
    +      clearIO();
    +      try {
    +         List<String> names = new ArrayList<>();
    --- End diff --
   
    using java 8 lambda's could be
   
    ```
            return server.getClusterManager().getClusterConnections().stream().map(ClusterConnection::getName).toArray(String[]::new);
    ```



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2439: ARTEMIS-2179 mgmnt method to get cluste...

rstancel
In reply to this post by rstancel
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2439


---