[GitHub] activemq-artemis pull request #2438: ARTEMIS-2178 routing-type config for co...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2438: ARTEMIS-2178 routing-type config for co...

asfgit
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2438

    ARTEMIS-2178 routing-type config for core bridge

    MULTICAST messages forwarded by a core bridge will not be routed to any
    ANYCAST queues and vice-versa. Diverts have the ability to configure how
    routing-type is treated. Core bridges now support this same kind of
    functionality. By default the bridge does not alter the routing-type of
    forwarded messages to maintain compatibility with existing behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2178

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2438.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2438
   
----
commit 1ae5db1432a56489162b36297f902cbaf5b84e38
Author: Justin Bertram <jbertram@...>
Date:   2018-11-20T03:24:35Z

    ARTEMIS-2178 routing-type config for core bridge
   
    MULTICAST messages forwarded by a core bridge will not be routed to any
    ANYCAST queues and vice-versa. Diverts have the ability to configure how
    routing-type is treated. Core bridges now support this same kind of
    functionality. By default the bridge does not alter the routing-type of
    forwarded messages to maintain compatibility with existing behavior.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2438: ARTEMIS-2178 routing-type config for co...

asfgit
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2438#discussion_r235527477
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/BridgeConfiguration.java ---
    @@ -75,6 +76,8 @@
        // The bridge shouldn't be sending blocking anyways
        private long callTimeout = ActiveMQClient.DEFAULT_CALL_TIMEOUT;
     
    +   private ComponentConfigurationRoutingType routingType = ComponentConfigurationRoutingType.valueOf(ActiveMQDefaultConfiguration.getDefaultDivertRoutingType());
    --- End diff --
   
    Should this not be default bridge routing type? (looks like picking up the divert default)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2438: ARTEMIS-2178 routing-type config for core brid...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2438
 
    This looks like a nice new feature, some docs maybe?
   
    Does this mean you could have a bridge that takes a message on an anycast queue, and send it to a multicast queue if the bridge is set routingtype to ComponentConfigurationRoutingType.MULTICAST?
   



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2438: ARTEMIS-2178 routing-type config for co...

asfgit
In reply to this post by asfgit
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2438#discussion_r235566861
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/BridgeConfiguration.java ---
    @@ -75,6 +76,8 @@
        // The bridge shouldn't be sending blocking anyways
        private long callTimeout = ActiveMQClient.DEFAULT_CALL_TIMEOUT;
     
    +   private ComponentConfigurationRoutingType routingType = ComponentConfigurationRoutingType.valueOf(ActiveMQDefaultConfiguration.getDefaultDivertRoutingType());
    --- End diff --
   
    Nice catch. Fixed.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2438: ARTEMIS-2178 routing-type config for core brid...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2438
 
    I thought I had added docs, but I must have mistaken the divert docs for this.  I added a section in the docs for this.


---