[GitHub] activemq-artemis pull request #2420: Allow configuration of RMI registry por...

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2420: Allow configuration of RMI registry por...

jbertram-2
GitHub user jsmucr opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2420

    Allow configuration of RMI registry port

    Previously the port was always random. This caused problems with remote JMX connections that needed to overcome firewalls. As of this patch, it's possible to make the RMI port static and whitelist it in the firewall settings.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jsmucr/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2420
   
----
commit 44b7a13f2f50ddc156eb51f9c11dc083da4a31dc
Author: Å mucr Jan <jan.smucr@...>
Date:   2018-11-07T13:49:23Z

    Allow configuration of RMI registry port
   
    Previously the port was always random. This caused problems with
    remote JMX connections that needed to overcome firewalls. As of
    this patch it's possible to make the RMI port static and whitelist
    it in the firewall settings.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    Have you confirmed that this change actually sets the RMI registry port as expected?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
In reply to this post by jbertram-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    Im not sure it does, i wrote this code and remember it not working well when i did the same thing. Also you can set this as a separate system property as per the docs


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    We fix the ports in my org this with using system properties on java command line modifiying artemis.profile


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
In reply to this post by jbertram-2
Github user jsmucr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    I think you mean something like this, right?
    ```JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote"
    JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.authenticate=false"
    JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.ssl=false"
    JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.port=1099"
    JAVA_ARGS="$JAVA_ARGS -Dcom.sun.management.jmxremote.rmi.port=1098"
    JAVA_ARGS="$JAVA_ARGS -Djava.rmi.server.hostname=edimq-broker-master-az1.dc01.clouedi.local"```
   
    This works but it's not how it's meant to be set up. The proper way is to set the port in the `management.xml` file and this patch allows you to set the RMI port there as well (using the `rmi-registry-port` attribute). It worked for me.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    @jsmucr maybe then an integration test to prove it, and also to make sure if it does work. No one breaks it on you


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
In reply to this post by jbertram-2
Github user jsmucr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    Okay. :)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
In reply to this post by jbertram-2
Github user jsmucr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    There, it's done. :) The way I had to test the port usage is nasty, sorry for that. Maybe someone will come up with something a little more straightforward.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2420: Allow configuration of RMI registry por...

jbertram-2
In reply to this post by jbertram-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2420


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2420: Allow configuration of RMI registry port

jbertram-2
In reply to this post by jbertram-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2420
 
    Just for the record...I opened a JIRA for this, squashed your commits, and referenced the JIRA in the commit message.  Thanks for the contribution, @jsmucr!


---