[GitHub] activemq-artemis pull request #2415: ARTEMIS-2100 address routing-type overr...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2415: ARTEMIS-2100 address routing-type overr...

jbertram-2
GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2415

    ARTEMIS-2100 address routing-type overridden on attaching AMQP sender

    AMQPSender has to honor an already existing multicast routingType
    of an address while attempting to create a fresh new queue on it

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-2100_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2415
   
----
commit 8a1a23cff8d74175a9e821985611136cd97805bc
Author: Francesco Nigro <nigro.fra@...>
Date:   2018-10-24T13:45:53Z

    ARTEMIS-2100 address routing-type overridden on attaching AMQP sender
   
    AMQPSender has to honor an already existing multicast routingType
    of an address while attempting to create a fresh new queue on it

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

jbertram-2
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2415
 
    I'm running a full CI run on this one to check if it is safe :+1:


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

jbertram-2
In reply to this post by jbertram-2
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2415
 
    According to the CI results:
    ![image](https://user-images.githubusercontent.com/13125299/47982793-4ed26c80-e0d1-11e8-9254-e9c15e2ae2e5.png)
    On the left is master, while on the right is this PR branch +1
    There are about 6 less failures and 1 more, but are almost intermittent ones, so it seems stable similarly to master.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

jbertram-2
In reply to this post by jbertram-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2415
 
    This looks fine


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...

jbertram-2
In reply to this post by jbertram-2
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2415
 
    @franz1981 Thanks for making the requested changes.  Merging


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2415: ARTEMIS-2100 address routing-type overr...

jbertram-2
In reply to this post by jbertram-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2415


---