[GitHub] activemq-artemis pull request #2410: ARTEMIS-2125 Tabs preference changes to...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2410: ARTEMIS-2125 Tabs preference changes to...

jbertram-2
GitHub user feuillemorte opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2410

    ARTEMIS-2125 Tabs preference changes to display columns not persistent through page refresh

    Fix based on
    https://github.com/apache/activemq-artemis/pull/2373
   
    Not all places was fixed. This fixes browse tab.
   
    After refreshing:
   
    FF:
   
    ![image](https://user-images.githubusercontent.com/9434344/47917052-97f3a800-dea8-11e8-93f5-06a9efec2e6c.png)
   
    Chrome:
   
    ![image](https://user-images.githubusercontent.com/9434344/47917078-a80b8780-dea8-11e8-8588-348824b6ad31.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/feuillemorte/activemq-artemis ARTEMIS-2125

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2410
   
----
commit ab24d1b9778e141f5f5e4369b7194c22ab4962cc
Author: feuillemorte <it@...>
Date:   2018-11-02T12:53:43Z

    ARTEMIS-2125 Tabs preference changes to display columns not persistent through page refresh

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2410: ARTEMIS-2125 Tabs preference changes to displa...

jbertram-2
Github user feuillemorte commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2410
 
    @tadayosi could you review it please?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2410: ARTEMIS-2125 Tabs preference changes to displa...

jbertram-2
In reply to this post by jbertram-2
Github user tadayosi commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2410
 
    @feuillemorte Sorry for the late response. Looks good to me!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2410: ARTEMIS-2125 Tabs preference changes to displa...

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2410
 
    thanks @feuillemorte for the contribution, and thanks @tadayosi for reviewing. merging now.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2410: ARTEMIS-2125 Tabs preference changes to...

jbertram-2
In reply to this post by jbertram-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2410


---