[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

jbertram-2
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2374

    ARTEMIS-2127 Add auth details to consumer created notification

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2127

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2374
   
----
commit 9d85168bcb18e5885ca8a7d394b7469df3f89c96
Author: Justin Bertram <jbertram@...>
Date:   2018-10-16T13:01:45Z

    ARTEMIS-2127 Add auth details to consumer created notification

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

jbertram-2
Github user sebthom commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2374#discussion_r225560766
 
    --- Diff: docs/user-manual/en/management.md ---
    @@ -735,8 +735,8 @@ un-formatted result of a call to `java.lang.System.currentTimeMillis()`.
     - `CONSUMER_CREATED` (2)
     
       `_AMQ_Address`, `_AMQ_ClusterName`, `_AMQ_RoutingName`, `_AMQ_Distance`,
    -  `_AMQ_ConsumerCount`, `_AMQ_User`, `_AMQ_RemoteAddress`,
    -  `_AMQ_SessionName`, `_AMQ_FilterString`
    +  `_AMQ_ConsumerCount`, `_AMQ_User`, `_AMQ_ValicatedUser`, `_AMQ_RemoteAddress`,
    --- End diff --
   
    I think there is a typo: _AMQ_Vali**c**atedUser ->_AMQ_Vali**d**atedUser


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

jbertram-2
In reply to this post by jbertram-2
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2374#discussion_r225561623
 
    --- Diff: docs/user-manual/en/management.md ---
    @@ -735,8 +735,8 @@ un-formatted result of a call to `java.lang.System.currentTimeMillis()`.
     - `CONSUMER_CREATED` (2)
     
       `_AMQ_Address`, `_AMQ_ClusterName`, `_AMQ_RoutingName`, `_AMQ_Distance`,
    -  `_AMQ_ConsumerCount`, `_AMQ_User`, `_AMQ_RemoteAddress`,
    -  `_AMQ_SessionName`, `_AMQ_FilterString`
    +  `_AMQ_ConsumerCount`, `_AMQ_User`, `_AMQ_ValicatedUser`, `_AMQ_RemoteAddress`,
    --- End diff --
   
    Nice catch!  I just pushed a fix.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2374: ARTEMIS-2127 Add auth details to consum...

jbertram-2
In reply to this post by jbertram-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2374


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2374: ARTEMIS-2127 Add auth details to consumer crea...

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2374
 
    LGTM, as no other review comments (its been 23 days), merging.


---