[GitHub] activemq-artemis pull request #2373: ARTEMIS-2125 Queue preference changes t...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2373: ARTEMIS-2125 Queue preference changes t...

spyrkob
GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2373

    ARTEMIS-2125 Queue preference changes to display columns not persistent through page refresh

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-2125

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2373
   
----
commit fe971a7a976cf24c4fe1c05b976099e509ecde53
Author: Tadayoshi Sato <sato.tadayoshi@...>
Date:   2018-10-15T05:38:43Z

    ARTEMIS-2125 Queue preference changes to display columns not persistent through page refresh

commit c4dd09cb8d41589a2156068bc0881df49e1149b3
Author: Francesco Nigro <nigro.fra@...>
Date:   2018-10-16T11:28:14Z

    ARTEMIS-2125 Tabs pref changes to display columns not persisted through page refresh

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2373: ARTEMIS-2125 Queue preference changes to displ...

spyrkob
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2373
 
    @tadayosi Please take a look if it is similar to what you have done on queues...and thanks for the PR :+1:


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2373: ARTEMIS-2125 Tabs preference changes to displa...

spyrkob
In reply to this post by spyrkob
Github user tadayosi commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2373
 
    Thanks @franz1981. This looks great!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2373: ARTEMIS-2125 Tabs preference changes to displa...

spyrkob
In reply to this post by spyrkob
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2373
 
    Lgtm


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2373: ARTEMIS-2125 Tabs preference changes to displa...

spyrkob
In reply to this post by spyrkob
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2373
 
    looks good I will merge.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2373: ARTEMIS-2125 Tabs preference changes to displa...

spyrkob
In reply to this post by spyrkob
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2373
 
    @andytaylor thanks!! I will cherry-pick into 2.6-x too :+1:


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2373: ARTEMIS-2125 Tabs preference changes to...

spyrkob
In reply to this post by spyrkob
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2373


---