[GitHub] activemq-artemis pull request #2193: ARTEMIS-1985: Switch from XA_RDONLY to ...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2193: ARTEMIS-1985: Switch from XA_RDONLY to ...

wy96f
GitHub user graben opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2193

    ARTEMIS-1985: Switch from XA_RDONLY to XA_OK as return value for prepare transaction via OpenWire

    @clebertsuconic : Feedback for possible test cases needed (https://issues.apache.org/jira/browse/ARTEMIS-1985)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/graben/activemq-artemis ARTEMIS-1985

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2193
   
----
commit 75b20b6553b374950dac333a1350783f0d29f937
Author: Benjamin Graf <benjamin.graf@...>
Date:   2018-07-21T14:57:12Z

    ARTEMIS-1985: Switch from XA_RDONLY to XA_OK as return value for prepare transaction via OpenWire

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2193: ARTEMIS-1985: Switch from XA_RDONLY to XA_OK a...

wy96f
Github user graben commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2193
 
    @clebertsuconic : Friendly reminder :-)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2193: ARTEMIS-1985: Switch from XA_RDONLY to XA_OK a...

wy96f
In reply to this post by wy96f
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2193
 
    @graben I wasn't sure what to do with this since there's no test.. I have no idea how to validate it yet.
   
    do you have any parallels to compare what would be the proper return.
   
    I know it's hard to test this since it needs a TM.. etc...


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2193: ARTEMIS-1985: Switch from XA_RDONLY to XA_OK a...

wy96f
In reply to this post by wy96f
Github user graben commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2193
 
    Yes, I commented in Jira that either via core protocol (Artemis) and ActiveMQ are returning XA_OK. Actually all events only get prepared and therefor data loss. My test case (simple program) only needs a few lines for the tm. I'm using geronimo tm which is easy to init.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2193: ARTEMIS-1985: Switch from XA_RDONLY to XA_OK a...

wy96f
In reply to this post by wy96f
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2193
 
    ok.. merging .. thanks for clarifying.. I have hard a hard time following so many emails :)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2193: ARTEMIS-1985: Switch from XA_RDONLY to ...

wy96f
In reply to this post by wy96f
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2193


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2193: ARTEMIS-1985: Switch from XA_RDONLY to XA_OK a...

wy96f
In reply to this post by wy96f
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2193
 
    pulled it into 2.6.x


---