[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

clebertsuconic-3
GitHub user JiriOndrusek opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2039

    [ARTEMIS-1823] - Log warning on boot when persistence is disabled and…

    … paging enabled
   
    Issue: https://issues.apache.org/jira/browse/ARTEMIS-1823
   
    Added warning in case that paging is on and persistence is disabled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1823

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2039.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2039
   
----
commit b4cf6aa37484be1b3aa1b9ce2438e0df289f97c7
Author: JiriOndrusek <jondruse@...>
Date:   2018-04-23T12:57:09Z

    [ARTEMIS-1823] - Log warning on boot when persistence is disabled and paging enabled

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

clebertsuconic-3
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2039#discussion_r183472200
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
    @@ -2323,6 +2324,16 @@ synchronized boolean initialisePart1(boolean scalingDown) throws Exception {
              deployAddressSettingsFromConfiguration();
           }
     
    +      //fix of ARTEMIS-1823
    +      if (!configuration.isPersistenceEnabled()) {
    +         for (AddressSettings addressSettings : addressSettingsRepository.values()) {
    +            if (addressSettings.getAddressFullMessagePolicy() == AddressFullMessagePolicy.PAGE) {
    +               ActiveMQServerLogger.LOGGER.pageWillBePersisted();
    --- End diff --
   
    really? did you have any user complaining about it?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user JiriOndrusek commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2039#discussion_r183613601
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
    @@ -2323,6 +2324,16 @@ synchronized boolean initialisePart1(boolean scalingDown) throws Exception {
              deployAddressSettingsFromConfiguration();
           }
     
    +      //fix of ARTEMIS-1823
    +      if (!configuration.isPersistenceEnabled()) {
    +         for (AddressSettings addressSettings : addressSettingsRepository.values()) {
    +            if (addressSettings.getAddressFullMessagePolicy() == AddressFullMessagePolicy.PAGE) {
    +               ActiveMQServerLogger.LOGGER.pageWillBePersisted();
    --- End diff --
   
    Hi, from the the issue text, it seems, that there is currently no customer complaining about this - https://issues.jboss.org/browse/JBEAP-10498. Do you think that this warning is senseless? (on the other hand it makes sense, when persistence is turned off, paging is still persisting - which has to be..)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2039#discussion_r184178629
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
    @@ -2323,6 +2324,16 @@ synchronized boolean initialisePart1(boolean scalingDown) throws Exception {
              deployAddressSettingsFromConfiguration();
           }
     
    +      //fix of ARTEMIS-1823
    +      if (!configuration.isPersistenceEnabled()) {
    +         for (AddressSettings addressSettings : addressSettingsRepository.values()) {
    +            if (addressSettings.getAddressFullMessagePolicy() == AddressFullMessagePolicy.PAGE) {
    +               ActiveMQServerLogger.LOGGER.pageWillBePersisted();
    --- End diff --
   
    I just don't think it's necessarily a Warning.. it's a feature!
   
    I don't agree to make this a WARN.. users using this on purpose will get a nonSense warning.
   
   
    if you want to log about the condition, I would make it INFO. as this is an intended feature.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user JiriOndrusek commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2039#discussion_r184335547
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
    @@ -2323,6 +2324,16 @@ synchronized boolean initialisePart1(boolean scalingDown) throws Exception {
              deployAddressSettingsFromConfiguration();
           }
     
    +      //fix of ARTEMIS-1823
    +      if (!configuration.isPersistenceEnabled()) {
    +         for (AddressSettings addressSettings : addressSettingsRepository.values()) {
    +            if (addressSettings.getAddressFullMessagePolicy() == AddressFullMessagePolicy.PAGE) {
    +               ActiveMQServerLogger.LOGGER.pageWillBePersisted();
    --- End diff --
   
    I agree with you. I've changed log level to INFO.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2039: [ARTEMIS-1823] - Log warning on boot wh...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2039


---