[GitHub] activemq-artemis pull request #2038: NO-JIRA Add option in CLI to specify a ...

Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2038: NO-JIRA Add option in CLI to specify a ...

jbertram-2
GitHub user rakstar opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2038

    NO-JIRA Add option in CLI to specify a queue routing type

    Optionally specify a queue routing type when creating a broker. Example:
    "create --queues myqueue,mytopic:multicast". Defaults to anycast if
    unspecified.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rakstar/activemq-artemis specify_queue_type

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2038
   
----
commit 70471eebf79b85b1e5b3453bf36edcd9b950b110
Author: King Ramos <rakstar@...>
Date:   2018-04-23T02:52:46Z

    NO-JIRA Add option in CLI to specify a queue routing type
   
    Optionally specify a queue routing type when creating a broker. Example:
    "create --queues myqueue,mytopic:multicast". Defaults to anycast if
    unspecified.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2038: NO-JIRA Add option in CLI to specify a queue r...

jbertram-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2038
 
    IMO this deserves a JIRA. I created https://issues.apache.org/jira/browse/ARTEMIS-1828. Can you change the commit message to include this JIRA, e.g.:
   
        ARTEMIS-1828 CLI option for queue's routing-type
   
    When you rebase and push -f this will also trigger a rebuild which hopefully will pass without any spurious errors.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2038: NO-JIRA Add option in CLI to specify a queue r...

jbertram-2
In reply to this post by jbertram-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2038
 
    Is this compatible with previous usages? what happens if I don't specify the rounting type?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2038: ARTEMIS-1828 CLI option for queue's routing-ty...

jbertram-2
In reply to this post by jbertram-2
Github user rakstar commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2038
 
    @jbertram Thanks for creating the issue. I updated my commit message and pushed (twice because I didn't rebase the first time, sorry).
   
    @clebertsuconic It is backward compatible as it defaults to anycast if unspecified. I indicate this in the CLI help as well.
   
    Thanks!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2038: ARTEMIS-1828 CLI option for queue's routing-ty...

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2038
 
    @rakstar Looks good, was about to merge this (sorry been a bit busy with broker fixes), unfortunately theres a merge conflict now, are you able to rebase / resolve?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2038: ARTEMIS-1828 CLI option for queue's routing-ty...

jbertram-2
In reply to this post by jbertram-2
Github user rakstar commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2038
 
    @michaelandrepearce Rebased and resolved. Thanks! :)


---