[GitHub] activemq-artemis pull request #2013: ARTEMIS-1805 fix for broker operations ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2013: ARTEMIS-1805 fix for broker operations ...

clebertsuconic-3
GitHub user stanlyDoge opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2013

    ARTEMIS-1805 fix for broker operations in hawtio

    There are two operations, which causes an error while selected in hawtio console under broker/operations. Adding @Operation annotation to these methods fixes an error, but methods are exposed and I am not 100% sure that is correct. I also unified capitalized first letter of methods description.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1805

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2013.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2013
   
----
commit 59f91f4c2e79777e40e5b220c0fad8faf63437e5
Author: Stanislav Knot <sknot@...>
Date:   2018-04-13T09:20:20Z

    ARTEMIS-1805 fix for broker operations in hawtio

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

clebertsuconic-3
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2013
 
    @stanlyDoge I didn't see that the two methods (sendQueueInfo.. and updateDuplicate...) in ActiveMQServerControl are used anywhere. Could simple deleting them from the interface solve the hawtio error?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user stanlyDoge commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2013
 
    @gaohoward Done.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2013
 
    @stanlyDoge you got to remove @Override annotations from ActiveMQServerControlImpl also.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user stanlyDoge commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2013
 
    @gaohoward Done.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #2013: ARTEMIS-1805 fix for broker operations ...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2013


---