[GitHub] activemq-artemis pull request #1982: JUnit rules to be usable against extern...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1982: JUnit rules to be usable against extern...

asfgit
GitHub user mohamnag opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1982

    JUnit rules to be usable against external secured broker

    as a companion to https://issues.apache.org/jira/browse/ARTEMIS-1778 this will allow using junit rules to be used against an external secured broker.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mohamnag/activemq-artemis patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1982.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1982
   
----
commit c85f30fbaee6d44e2cd49f88c3c95339c98213d8
Author: Mohammad Naghavi <mohamnag@...>
Date:   2018-03-29T21:19:46Z

    username and passowrd as part of junit rule
   
    enable username and passowrd to be provided as part of junit rule

commit eee7e59442f307c620835d6cb0b400c3bb68c028
Author: Mohammad Naghavi <mohamnag@...>
Date:   2018-03-29T21:49:10Z

    adding username and password for all junit rules

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1982
 
    Couple of things related to your commit:
   
    1.  The commits should be squashed.
    2.  The commit message should follow the recommendation from the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).
    3.  The CI build failed due to checkstyle violations.
   
    Aside from that, can you elaborate a bit on the use-case here?  Why not just use the normal API to connect to the remote broker?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

asfgit
In reply to this post by asfgit
Github user mohamnag commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1982
 
    @jbertram thanks for comments, I just opened this to check for the CI, so I will fix it asap.
   
    regarding your last sentence, what do you mean using normal API? Is there a way I can use these JUnit rules with external broker that has security enabled? any way to provide username and password?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1982
 
    @mohamnag, by "normal API" I mean "a client API which is normally used by remote clients (e.g. 'core' API or JMS API)." As I see it, most of the power in the Artemis JUnit resources comes from being able to easily inject, configure, and run an embedded broker. If you aren't leveraging that capability it seems just as easy to use something like core or JMS 2 to connect to the external broker.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1982
 
    @jbertram There's a Junit module for users to use on their testsuite.
   
    It's nice to see a PR here. it means people are using it.
   
    @mohamnag can you squash those and fix checkstyle?
   
    after squashing.. you can just do git push origin -f on your branch, and this PR will be updated.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

asfgit
In reply to this post by asfgit
Github user mohamnag commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1982
 
    @clebertsuconic I tried this week to find some time doing so, but it was a busy one. Will try to do it on weekend.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1982
 
    @mohamnag, any update on this?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1982
 
    Here's the related Stack Overflow discussion: https://stackoverflow.com/questions/49564252/jms-test-util-for-junit-or-spock.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1982: JUnit rules to be usable against extern...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1982


---