[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...

asfgit
GitHub user rstancel opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1975

    [ARTEMIS-1761] Log warning if cluster is not able to connect at startup

    Jira: https://issues.apache.org/jira/browse/ARTEMIS-1761
    master commit: https://github.com/apache/activemq-artemis/commit/373c3db2ac4c3b79d4f777ee32498c924176eba6

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1761_1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1975
   
----
commit 6c397fda732837191c63e65507ad58a16b25bf70
Author: Radovan Stancel <rstancel@...>
Date:   2018-03-21T17:26:20Z

    [ARTEMIS-1761] Log warning if cluster is not able to connect at startup

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1975: [ARTEMIS-1761] Log warning if cluster is not a...

asfgit
Github user rstancel commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1975
 
    @clebertsuconic Clebert, can you please merge also this PR? thanks


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1975#discussion_r179841255
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java ---
    @@ -930,9 +930,7 @@ protected void connect() {
                    scheduleRetryConnectFixedTimeout(this.retryInterval);
                    return;
                 } else {
    -               if (logger.isDebugEnabled()) {
    -                  logger.debug("Bridge " + this + " is unable to connect to destination. Retrying", e);
    --- End diff --
   
    Can you still keep the log.debug?
   
    Didn't I see you doing this somewhere else? is that the same issue?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...

asfgit
In reply to this post by asfgit
Github user rstancel commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1975#discussion_r180048729
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java ---
    @@ -930,9 +930,7 @@ protected void connect() {
                    scheduleRetryConnectFixedTimeout(this.retryInterval);
                    return;
                 } else {
    -               if (logger.isDebugEnabled()) {
    -                  logger.debug("Bridge " + this + " is unable to connect to destination. Retrying", e);
    --- End diff --
   
    @clebertsuconic it was different issues. https://github.com/apache/activemq-artemis/pull/1990 . Should I create new PR in master?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1975: [ARTEMIS-1761] Log warning if cluster is not a...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1975
 
    I think this PR is moot at this point as this change is on the master and 2.6.x branches (and Wildfly has moved to 2.6.x). @rstancel, can you close this PR?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1975: [ARTEMIS-1761] Log warning if cluster is not a...

asfgit
In reply to this post by asfgit
Github user rstancel commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1975
 
    Closing this PR as requested by Justin Bertram @jbertram


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...

asfgit
In reply to this post by asfgit
Github user rstancel closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1975


---