[GitHub] activemq-artemis pull request #1856: ARTEMIS-853 Support for exclusive consu...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1856: ARTEMIS-853 Support for exclusive consu...

asfgit
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1856

    ARTEMIS-853 Support for exclusive consumers

    Alternative QueueImpl - Seperated logic without counters

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-853-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1856.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1856
   
----
commit 87ecda7ed5b09774c23f3de16bff2b20971db015
Author: Michael André Pearce <michael.andre.pearce@...>
Date:   2018-02-07T21:07:44Z

    ARTEMIS-853 Support for exclusive consumers
   
    Alternative QueueImpl - Seperated logic without counters

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1856: ARTEMIS-853 Support for exclusive consumers

asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1856
 
    @clebertsuconic as per your comment to look at an alternative QueueImpl with it having separate flow without counters for exclusive.
   
    IMO i don't think this is a better approach, but i want to offer it to you.
     
    There is an amount of logic that is almost similar but not re-usable or abstract-able (ive done what i could).
   
    This is why i followed the same logic that MessageGroups does when a group already is assigned,
     which is to override the consumer and then don't update the pos, as it made for a lot smaller change, less intrusive change following a pattern already done with msg groups.
   
    Anyhow if you prefer this then im not dead opposed to this approach just don't think its better, but i offer it for your review.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1856: ARTEMIS-853 Support for exclusive consumers

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1856
 
    I will need to look on this on Monday.  Will be traveling for a few days.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1856: ARTEMIS-853 Support for exclusive consumers

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1856
 
    I’m closing this as no further comments.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1856: ARTEMIS-853 Support for exclusive consu...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1856


---