[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
GitHub user treblereel opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1852

    [ARTEMIS-1662] Reduce log of "INFO [org.apache.activemq.artemis.core.…

    …client] (Thread-27 (ActiveMQ-client-global-threads))
   
    jira: https://issues.apache.org/jira/browse/ARTEMIS-1662

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/treblereel/activemq-artemis-wildfly JBEAP-14167

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1852
   
----
commit 7f70ad9aa5f9dff4032f05acbc8fb289e99c1676
Author: Dmitrii Tikhomirov <dtikhomi@...>
Date:   2018-02-05T11:55:48Z

    [ARTEMIS-1662] Reduce log of "INFO [org.apache.activemq.artemis.core.client] (Thread-27 (ActiveMQ-client-global-threads))

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r165977653
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    Client side this is very useful information, and should only occur on connection


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user treblereel commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r165982642
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    @michaelandrepearce ok, let me take a look


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r165983987
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    Probably one option would be to make NettyConnector take a boolean value isServerConnection or something, then later
   
          if (isServerConnection) {
             ActiveMQClientLogger.LOGGER.startedServerNettyConnector(connectorType,  TransportConstants.NETTY_VERSION, host, port);
          } else {
             ActiveMQClientLogger.LOGGER.startedNettyConnector(connectorType,  TransportConstants.NETTY_VERSION, host, port);
          }
   
    Where the startedServerNettyConnector could log at DEBUG


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user treblereel commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r165997110
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    @michaelandrepearce, thanks, i am trying to do the same fix atm



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r167242748
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    @michaelandrepearce I was actually considering doing this myself... the clients are too verbose.. some users will open and create connections all the time.. this becomes too verbose.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r167261076
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    Agreed server side, but client side this is far too useful to lose.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r167269720
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    @michaelandrepearce actually this is getting too verbose on clients.
    We can use log.debug on the client... and you can increase logger if you really want it.
   
    Some users will complain the opposite.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1852


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1852: [ARTEMIS-1662] Reduce log of "INFO [org...

jbertram-2
In reply to this post by jbertram-2
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1852#discussion_r167332364
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ---
    @@ -64,7 +64,7 @@
        @Message(id = 211001, value = "session created", format = Message.Format.MESSAGE_FORMAT)
        void dumpingSessionStack(@Cause Exception e);
     
    -   @LogMessage(level = Logger.Level.INFO)
    +   @LogMessage(level = Logger.Level.DEBUG)
    --- End diff --
   
    disagree still but as its 2 v 1 and its logging at the end of the day (bigger issues to really worry on) ill make it a -0. Ive merged the PR as is.


---