[GitHub] activemq-artemis pull request #1835: ARTEMIS-1651 Allow custom etc and data ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1835: ARTEMIS-1651 Allow custom etc and data ...

asfgit
GitHub user dejanb opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1835

    ARTEMIS-1651 Allow custom etc and data directories to be used

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dejanb/activemq-artemis cli

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1835.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1835
   
----
commit 2aa0996b4f83fab3e1d922016df9570a22b63c75
Author: Dejan Bosanac <dejan@...>
Date:   2018-01-24T10:50:22Z

    ARTEMIS-1632 Upgrade JBoss logging to 3.3.1.Final

commit 51ae5f54f85f72f5cfb2c0099c2fff37c18b2d84
Author: Dejan Bosanac <dejan@...>
Date:   2018-01-26T14:26:47Z

    ARTEMIS-1651 Allow custom etc and data directories to be used
   
    initial support for custom etc location
   
    fixing windows distribution

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1835
 
    PR build failures look legitimate to me.  I reproduced them locally.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

asfgit
In reply to this post by asfgit
Github user dejanb commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1835
 
    @jbertram Thanks. I forgot to update the test. Can you give a test now?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1835
 
    I checked out your branch, and I still see the failures.  Does everything in org.apache.activemq.cli.test.ArtemisTest pass for you?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

asfgit
In reply to this post by asfgit
Github user dejanb commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1835
 
    @jbertram yeah, I need to recheck all tests. Thanks!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1835
 
    Can you squash these commits, @dejanb?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1835: ARTEMIS-1651 Allow custom etc and data directo...

asfgit
In reply to this post by asfgit
Github user dejanb commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1835
 
    @jbertram done!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1835: ARTEMIS-1651 Allow custom etc and data ...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1835


---