[GitHub] activemq-artemis pull request #1766: ARTEMIS-1596 STOMP consumer/producer au...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1766: ARTEMIS-1596 STOMP consumer/producer au...

jbertram-2
GitHub user jostbg opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1766

    ARTEMIS-1596 STOMP consumer/producer auto-creates address with wrong routing-type

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jostbg/activemq-artemis ARTEMIS-1596

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1766
   
----
commit 67f29c4670e594613c5e794ec512d68f66881b7c
Author: jostbg <35264802+jostbg@...>
Date:   2018-01-10T16:29:29Z

    ARTEMIS-1596 STOMP consumer/producer auto-creates address with wrong routing-type

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1766: ARTEMIS-1596 STOMP consumer/producer auto-crea...

jbertram-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1766
 
    You should squash these commits together into a single commit and also add a test to reproduce the failure and verify the fix.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1766: ARTEMIS-1596 STOMP consumer/producer auto-crea...

jbertram-2
In reply to this post by jbertram-2
Github user jostbg commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1766
 
    @jbertram before I do so, I got one question. The original code was a bit unclear so I did some guessing, but should the queue only auto-created when the "address" routing type is not MULTICAST or always, i.e. is this assumption correct: https://github.com/apache/activemq-artemis/pull/1766/commits/3d0680e351db6cac65d087f33326405860961507#diff-2be6e6baef830595c16a9daa3d951615R283


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1766: ARTEMIS-1596 STOMP consumer/producer auto-crea...

jbertram-2
In reply to this post by jbertram-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1766
 
    Your assumption is correct.  Do not auto-create the queue if the routing-type is MULTICAST.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1766: ARTEMIS-1596 STOMP consumer/producer auto-crea...

jbertram-2
In reply to this post by jbertram-2
Github user jostbg commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1766
 
    Done.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1766: ARTEMIS-1596 STOMP consumer/producer au...

jbertram-2
In reply to this post by jbertram-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1766


---