[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

jgoodyear-2
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1764

    ARTEMIS-1595 Fixing serialization issues between Artemis 1.5 and master

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis serialization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1764.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1764
   
----
commit 37b89625b929ea1966dd534d47de9c60e133bee4
Author: Clebert Suconic <clebertsuconic@...>
Date:   2018-01-10T01:27:17Z

    ARTEMIS-1595 Fixing serialization issues between Artemis 1.5 and master

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

jgoodyear-2
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1764#discussion_r160573966
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java ---
    @@ -143,6 +143,8 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
              }
           }
     
    +
    +      // the innitial communication happens here...
    --- End diff --
   
    hahaha you left this in from the web conf :)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user jmesnil commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605068
 
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java ---
    @@ -188,13 +189,15 @@ public void setDeserializationWhiteList(String whiteList) {
        @Override
        public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
           String url = in.readUTF();
    +      System.out.println("Reading " + url);
    --- End diff --
   
    should be removed


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user jmesnil commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605042
 
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java ---
    @@ -95,6 +95,7 @@ public void writeExternal(ObjectOutput out) throws IOException {
           URI uri = toURI();
     
           try {
    +         System.out.println("writing " + uri.toASCIIString());
    --- End diff --
   
    should be removed


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user jmesnil commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1764#discussion_r160605094
 
    --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnectionFactory.java ---
    @@ -188,13 +189,15 @@ public void setDeserializationWhiteList(String whiteList) {
        @Override
        public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
           String url = in.readUTF();
    +      System.out.println("Reading " + url);
           ConnectionFactoryParser parser = new ConnectionFactoryParser();
           ServerLocatorParser locatorParser = new ServerLocatorParser();
           try {
              URI uri = new URI(url);
              serverLocator = locatorParser.newObject(uri, null);
              parser.populateObject(uri, this);
           } catch (Exception e) {
    +         e.printStackTrace();
    --- End diff --
   
    should be removed


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1764: ARTEMIS-1595 Fixing serialization issues betwe...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1764
 
    Forgot those. Will remove them.
   
   
    Thanks for catching this.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1764#discussion_r160689970
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java ---
    @@ -143,6 +143,8 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
              }
           }
     
    +
    +      // the innitial communication happens here...
    --- End diff --
   
    ouch.. I will separate this commit and keep it :)
    Live coding!!!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1764: ARTEMIS-1595 Fixing serialization issues betwe...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1764
 
    @jmesnil all fixed


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1764: ARTEMIS-1595 Fixing serialization issues betwe...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1764
 
    +1 will merge


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1764: ARTEMIS-1595 Fixing serialization issue...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1764


---