[GitHub] activemq-artemis pull request #1762: ARTEMIS-1580 Browsing in hawtio console...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1762: ARTEMIS-1580 Browsing in hawtio console...

michaelandrepearce-2
GitHub user stanlyDoge opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1762

    ARTEMIS-1580 Browsing in hawtio console does not allow to show empty …

    …pages

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1580

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1762
   
----
commit c649bc5b64b57c3541125e0ddd38b479bf9d07ac
Author: Stanislav Knot <sknot@...>
Date:   2018-01-09T16:17:49Z

    ARTEMIS-1580 Browsing in hawtio console does not allow to show empty pages

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1762: ARTEMIS-1580 Browsing in hawtio console does n...

michaelandrepearce-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1762
 
    LGTM, @mtaylor you had a chance to look at this? would like a thumps up from you also before i merge.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1762: ARTEMIS-1580 Browsing in hawtio console does n...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1762
 
    @michaelandrepearce We still have the same problem in the management methods.  But, I'd argue that's dumb input.  This seems fine to me +1.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1762: ARTEMIS-1580 Browsing in hawtio console...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1762


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1762: ARTEMIS-1580 Browsing in hawtio console does n...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1762
 
    @stanlyDoge thanks for this 👍 great contribution. Have merged.


---