[GitHub] activemq-artemis pull request #1760: ARTEMIS-1593 RemotingConnectionImpl lea...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1760: ARTEMIS-1593 RemotingConnectionImpl lea...

jgoodyear-2
GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1760

    ARTEMIS-1593 RemotingConnectionImpl leaks

    FileNameKey was holding a reference to PropertiesLoader.this due to its inner class definition, causing RemotingConnectionImpl to leak through a long chain of dependencies rooted in a PropertiesLoader's subclass property ie PropertiesLoaderModule::callbackHandler.
    FileNameKey is turned into a inner static class to break this hidden dependency.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1760
   
----
commit ca7e0a1e6fc088e17e3c907e974ef7e57db752f3
Author: Francesco Nigro <nigro.fra@...>
Date:   2018-01-09T14:12:44Z

    ARTEMIS-1593 RemotingConnectionImpl leaks
   
    FileNameKey was holding a reference to PropertiesLoader.this due to its inner class definition, causing RemotingConnectionImpl to leak through a long chain of dependencies rooted in a PropertiesLoader's subclass property ie PropertiesLoaderModule::callbackHandler.
    FileNameKey is turned into a inner static class to break this hidden dependency.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1760: ARTEMIS-1593 RemotingConnectionImpl leaks

jgoodyear-2
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1760
 
    This PR is addressing an issue present into master and found on https://github.com/apache/activemq-artemis/pull/1757


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1760: ARTEMIS-1593 RemotingConnectionImpl leaks

jgoodyear-2
In reply to this post by jgoodyear-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1760
 
    +1 LGTM will wait for PR build to complete successfully if thats ok


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1760: ARTEMIS-1593 RemotingConnectionImpl leaks

jgoodyear-2
In reply to this post by jgoodyear-2
Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1760
 
    @michaelandrepearce Sure! Anyway this was a very subtle leak :O


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1760: ARTEMIS-1593 RemotingConnectionImpl lea...

jgoodyear-2
In reply to this post by jgoodyear-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1760


---