[GitHub] activemq-artemis pull request #1683: ARTEMIS-1532 Enable tests which are uni...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1683: ARTEMIS-1532 Enable tests which are uni...

pgfox
GitHub user jdanekrh opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1683

    ARTEMIS-1532 Enable tests which are unintentionally skipped by Surefire

    This is not ready to be merged, because `HAAutomaticBackupSharedStoreTest` and `testSystemPropertyOverride` are failing after these changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/activemq-artemis jd_skipped_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1683
   
----
commit 63cdbc4c26cbd419a8303a8b9796a0cdf4613b99
Author: Jiri Danek <[hidden email]>
Date:   2017-12-03T18:44:58Z

    ARTEMIS-1532 Enable tests which are unintentionally skipped by Surefire
   
    These tests used to have a wrong name, so they weren't executed by
    Surefire during a `mvn test` run.
   
    After enablement, the following tests are now failing:
   
    org.apache.activemq.artemis.tests.integration.cluster.ha.HAAutomaticBackupSharedStoreTest
    org.apache.activemq.artemis.tests.integration.ra.OutgoingConnectionNoJTATest

commit 380980b2c58a716cdbf8b81b2f5a9cba080d16c6
Author: Jiri Danek <[hidden email]>
Date:   2017-12-03T18:56:47Z

    ARTEMIS-1532 Fix OutgoingConnectionNoJTATest

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1683: ARTEMIS-1532 Enable tests which are unintentio...

pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1683
 
    Are you sure it was unintentional ?
   
    I’m not on a computer now. But I remember a few tests that were commented out instead of removed to be checked later and we never got back to them.  


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1683: ARTEMIS-1532 Enable tests which are unintentio...

pgfox
In reply to this post by pgfox
Github user jdanekrh commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1683
 
    Well, I might've guessed the intent wrong in one or two cases, I guess.
   
    If I thought it is unintentional, I've either renamed the class (so that Surefire would pick it) or added the @Test annotation.
   
    If I thought it is intentional, I've added @Ignored annotation instead of whichever other method was used to disable that test.


---