[GitHub] activemq-artemis pull request #1678: ARTEMIS-1529 Fixing Ref count over asyn...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1678: ARTEMIS-1529 Fixing Ref count over asyn...

pgfox
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1678

    ARTEMIS-1529 Fixing Ref count over asynchronous ack

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1529

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1678
   
----
commit f989a7ae959b9a61ac3dcfedcae0541ba402508f
Author: Tomas Kratky <[hidden email]>
Date:   2017-11-28T21:37:46Z

    ARTEMIS-1529 Adding test on durable topics

commit ee6a0fe6fadf670e4691b2e19e21aaef8b79d92d
Author: Clebert Suconic <[hidden email]>
Date:   2017-11-29T02:08:05Z

    ARTEMIS-1529 Fixing Ref count over asynchronous ack

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1678: ARTEMIS-1529 Fixing Ref count over asynchronou...

pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1678
 
    @tkratky I am adding the test you create through this PR.. attributing the authorship to you.
   
    if you could review please?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1678: ARTEMIS-1529 Fixing Ref count over asynchronou...

pgfox
In reply to this post by pgfox
Github user kornys commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1678
 
    @clebertsuconic dothese tests pass with current fixes?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1678: ARTEMIS-1529 Fixing Ref count over asynchronou...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1678
 
    with this fix, yes


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1678: ARTEMIS-1529 Fixing Ref count over asynchronou...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1678
 
    please, do not merge this yet


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1678: ARTEMIS-1529 Fixing Ref count over asynchronou...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1678
 
    it's fine now.. false alarm


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1678: ARTEMIS-1529 Fixing Ref count over asyn...

pgfox
In reply to this post by pgfox
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1678


---