[GitHub] activemq-artemis pull request #1677: Allow mqtt with dynamic cluster

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1677: Allow mqtt with dynamic cluster

pgfox
GitHub user Skiler opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1677

    Allow mqtt with dynamic cluster

    https://issues.apache.org/jira/browse/ARTEMIS-1523


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Skiler/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1677
   
----
commit f506885272b7d074ba12f14d3831e3c4357aad46
Author: raul.valdoleiros <[hidden email]>
Date:   2017-11-24T17:53:14Z

    Mqtt cluster

commit c502b2c71d91fb8420f214814d9926c98b203fa3
Author: raul.valdoleiros <[hidden email]>
Date:   2017-11-28T15:45:34Z

    Merge remote-tracking branch 'upstream/master'

commit ef36451e5da2ad8db5c33ecc1f6ac5b28d249a5f
Author: raul.valdoleiros <[hidden email]>
Date:   2017-11-24T17:53:14Z

    Mqtt cluster

commit 0f9ae82ab12b751bfe70d34ac5977454943dc200
Author: raul.valdoleiros <[hidden email]>
Date:   2017-11-28T15:44:26Z

    ARTEMIS-1523 Fixing mqtt dynamic cluster
   
    Now artemis uses the message-load-balacing property of cluster connection to share the mqtt message between brokers

commit a7d115f30437ea2c2465f1af17768f69c973af48
Author: raul.valdoleiros <[hidden email]>
Date:   2017-11-28T15:51:03Z

    ARTEMIS-1523 Fix pom

commit f10ce5e91a1094aaaeac2015b77d900cbb3f0b66
Author: raul.valdoleiros <[hidden email]>
Date:   2017-11-28T15:52:36Z

    ARTEMIS-1523 Fix versions

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1677: Allow mqtt with dynamic cluster

pgfox
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1677
 
    Your commits should be broken into logical units with clear descriptions of what you're fixing and why. Looking at the commits you should probably have 1 where you add the example and then another where you fix the problem.
   
    To be clear, I'm not indicating the fix is valid at this point as it's not clear to me what specifically you're fixing and why.  The commits need to be better organized before I can actually get to that point.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1677: Allow mqtt with dynamic cluster

pgfox
In reply to this post by pgfox
Github user Skiler commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1677
 
    Hi @jbertram,
    Can you help me understand how the commits should be organized?
   
    The commit "Mqtt cluster" has the scenario I want to test.
    The commit "ARTEMIS-1523 Fixing mqtt dynamic cluster" is the fix for that scenario.
    The other commits are just pom stuff.
   
    In the scenario you have:
   
    - two brokers using dynamic cluster (I think is the right term) and receiving mqtt messages
    - the brokers have a queue configured with anycast
    - two consumers, each one subscribing the broker 1 and the other subscribing the broker 2
    - one producer sending 3 messages to broker 1
   
    The goal is to receive the the first and third message in the consumer 1 and the second message in the broker 2.
   
    Thanks


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1677: Allow mqtt with dynamic cluster

pgfox
In reply to this post by pgfox
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1677
 
    > Can you help me understand how the commits should be organized?
    Commits should be organized into logical units.  You shouldn't have a commit adding the example and then a handful of smaller commits fixing stuff in the example you added in a previous commit.  All those commits should be squashed together into a single commit and then the commit message should follow the recommendation from the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages). Git makes it easy to manipulate commits so take advantage of its power.
   
    Once everything is organized in a sane manner I'll take a look at the actual commit (assuming I have time).


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1677: Allow mqtt with dynamic cluster

pgfox
In reply to this post by pgfox
Github user Skiler closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1677


---