[GitHub] activemq-artemis pull request #1676: [ARTEMIS-1527] - [Artemis Testsuite] Ac...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1676: [ARTEMIS-1527] - [Artemis Testsuite] Ac...

clebertsuconic-3
GitHub user JiriOndrusek opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1676

    [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQMessageHandlerTest#testS…

    …erverShutdownAndReconnect fails
   
    Issue: https://issues.apache.org/jira/browse/ARTEMIS-1527

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1527

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1676
   
----
commit 354409952ed7cd3c9d7883e21389e75ed9a022b5
Author: JiriOndrusek <[hidden email]>
Date:   2017-11-22T14:38:03Z

    [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQMessageHandlerTest#testServerShutdownAndReconnect fails

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1676: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

clebertsuconic-3
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1676
 
    The failover is blocking because client applications would fail and would require to block.. it's customer's code.
   
    I reckon we could do asynchronously for MDBs or message listeners. so, how do you differentiate the two here?
   
   
    I suspect Failover (FailoverTest and others on the testsuite) wouldn't work.
   
   
    Also.. at least you should make this change on master.. it's a significant refactoring to make something like this to work properly. Failover itself was a pain.. making this level.. even more difficult.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1676: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1676
 
    @clebertsuconic The problem here is that any thread that blocks indefinitely takes up resources in the Thread pool.  If you have several threads trying reconnect, the ThreadPool may be exhausted and can not be used to perform any other tasks.  My opinion here is that no task we add to the ThreadPool should block indefinitely, for retry here we should attempt to connect, if it fails schedule another attempt connect call, and give up the thread.  Jiri's made a start on that, but we may need to flesh out some of the details.  There's a similar problem with LargeMessage receive().


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1676: [ARTEMIS-1527] - [Artemis Testsuite] ActiveMQM...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user JiriOndrusek commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1676
 
    Thank you for your responses.
   
    @clebertsuconic you are right, with this change FailoverTest is failing
   
    I'll try to find solution for FailoverTest to succeed.
    (it will take me some time to debug and understand it)
   
    @clebertsuconic @mtaylor I'm opened to any suggestions, as there are a lot of aspects, about which I don't know/understand.


---