[GitHub] activemq-artemis pull request #1657: NO-JIRA Adding tests

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1657: NO-JIRA Adding tests

michaelandrepearce-2
GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1657

    NO-JIRA Adding tests

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1657.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1657
   
----
commit 6aebb45c08a5f13a7d61982d330242d21803169b
Author: Andy Taylor <[hidden email]>
Date:   2017-11-14T16:42:03Z

    NO-JIRA Adding tests

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

michaelandrepearce-2
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1657
 
    @andytaylor Could you ammend the commit message to something more descriptive please.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1657: NO-JIRA Adding tests

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1657#discussion_r151215473
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/AdvisoryOpenWireTest.java ---
    @@ -0,0 +1,148 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.tests.integration.openwire;
    +
    +import org.apache.activemq.artemis.api.core.management.AddressControl;
    +import org.apache.activemq.artemis.api.core.management.QueueControl;
    +import org.apache.activemq.artemis.tests.util.Wait;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import javax.jms.Connection;
    +import javax.jms.Session;
    +import javax.jms.TemporaryQueue;
    +import javax.jms.TemporaryTopic;
    +
    +public class AdvisoryOpenWireTest extends BasicOpenWireTest {
    +
    +   @Override
    +   @Before
    +   public void setUp() throws Exception {
    +      //this system property is used to construct the executor in
    +      //org.apache.activemq.transport.AbstractInactivityMonitor.createExecutor()
    +      //and affects the pool's shutdown time. (default is 30 sec)
    +      //set it to 2 to make tests shutdown quicker.
    +      System.setProperty("org.apache.activemq.transport.AbstractInactivityMonitor.keepAliveTime", "2");
    --- End diff --
   
    This kind of thing is a potential source of issues on another tests...
   
    Can you cleanup the property on a tearDown please?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1657: NO-JIRA Adding tests

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1657#discussion_r151215558
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/AdvisoryOpenWireTest.java ---
    @@ -0,0 +1,148 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.tests.integration.openwire;
    +
    +import org.apache.activemq.artemis.api.core.management.AddressControl;
    +import org.apache.activemq.artemis.api.core.management.QueueControl;
    +import org.apache.activemq.artemis.tests.util.Wait;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import javax.jms.Connection;
    +import javax.jms.Session;
    +import javax.jms.TemporaryQueue;
    +import javax.jms.TemporaryTopic;
    +
    +public class AdvisoryOpenWireTest extends BasicOpenWireTest {
    +
    +   @Override
    +   @Before
    +   public void setUp() throws Exception {
    +      //this system property is used to construct the executor in
    +      //org.apache.activemq.transport.AbstractInactivityMonitor.createExecutor()
    +      //and affects the pool's shutdown time. (default is 30 sec)
    +      //set it to 2 to make tests shutdown quicker.
    +      System.setProperty("org.apache.activemq.transport.AbstractInactivityMonitor.keepAliveTime", "2");
    --- End diff --
   
    Also +1 on @mtaylor ... a better description of the test you added would be great.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1657
 
    I just moved these tests from another class and added slightly different assertion.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1657
 
    @andytaylor ok.. the issue is just duplicated now ...
   
    I can take care of the other property. What would be a better commit description here?
   
    "NO-JIRA Adding Advisory OpenWire tests"
   
    ???
   
   
    I can amend this and take care of the systemproperty myself. if you say it's ok the commit name.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1657: NO-JIRA Adding tests

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1657
 
    yeah thats fine, cheers


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1657: NO-JIRA Adding tests

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1657


---