[GitHub] activemq-artemis pull request #1655: ARTEMIS-1514 Large message fix

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1655: ARTEMIS-1514 Large message fix

michaelandrepearce-2
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1655

    ARTEMIS-1514 Large message fix

    I'm doing an overal improvement on large message support for AMQP
    However this commit is just about a Bug on the converter.
   
    It will be moot after all the changes I'm making, but I would rather keep this separate
    as a way to cherry-pick on previous versions eventually.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis amqp-large-message

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1655.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1655
   
----
commit 5e1ae7aa029d4ea53335a893d25bcbe39f4ca423
Author: Clebert Suconic <[hidden email]>
Date:   2017-11-13T21:36:47Z

    ARTEMIS-1514 Large message fix
   
    I'm doing an overal improvement on large message support for AMQP
    However this commit is just about a Bug on the converter.
   
    It will be moot after all the changes I'm making, but I would rather keep this separate
    as a way to cherry-pick on previous versions eventually.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1655: ARTEMIS-1514 Large message fix

michaelandrepearce-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1655
 
    I'm still refactoring large messages, but this change is independent as it may be picked on previous versions (1.x for instance).


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1655: ARTEMIS-1514 Large message fix

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1655
 
    @clebertsuconic Looks like the PR tests failed, but the failed result seems to be lost so I'm unable to restart.  Could you open another PR or push a change to get this to rerun.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1655: ARTEMIS-1514 Large message fix

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1655
 
    I got the PR tests to complete on my personal server. Something env at apache.. the tests here are good.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1655: ARTEMIS-1514 Large message fix

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1655


---