[GitHub] activemq-artemis pull request #1653: ARTEMIS-1510 refactor Maven poms

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1653: ARTEMIS-1510 refactor Maven poms

michaelandrepearce-2
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1653

    ARTEMIS-1510 refactor Maven poms

    Clean up unused declared dependencies and undeclared dependencies which
    are pulled in transitively.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1653.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1653
   
----
commit d931fd60dda7fb072b801b973ab3bef3b2ead89e
Author: Justin Bertram <[hidden email]>
Date:   2017-10-31T13:19:00Z

    ARTEMIS-1510 refactor Maven poms
   
    Clean up unused declared dependencies and undeclared dependencies which
    are pulled in transitively.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1653: ARTEMIS-1510 refactor Maven poms

michaelandrepearce-2
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1653#discussion_r150548048
 
    --- Diff: artemis-core-client/pom.xml ---
    @@ -65,6 +71,12 @@
              <scope>test</scope>
           </dependency>
           <dependency>
    +         <groupId>org.hamcrest</groupId>
    --- End diff --
   
    what was bringing that transitively?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1653: ARTEMIS-1510 refactor Maven poms

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1653#discussion_r150556595
 
    --- Diff: artemis-core-client/pom.xml ---
    @@ -65,6 +71,12 @@
              <scope>test</scope>
           </dependency>
           <dependency>
    +         <groupId>org.hamcrest</groupId>
    --- End diff --
   
    It's imported by org.apache.activemq.artemis.api.core.TransportConfigurationTest.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1653: ARTEMIS-1510 refactor Maven poms

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1653


---