[GitHub] activemq-artemis pull request #1643: ARTEMIS-1502 added addressMemorySize an...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1643: ARTEMIS-1502 added addressMemorySize an...

michaelandrepearce-2
GitHub user pgfox opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1643

    ARTEMIS-1502 added addressMemorySize and paging info to addresslist

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pgfox/activemq-artemis address_view_changes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1643.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1643
   
----
commit d6d55afe1895212fe2123a395c184d04651c35ed
Author: Pat Fox <[hidden email]>
Date:   2017-11-05T13:03:58Z

    ARTEMIS-1502 added addressMemorySize and  paging info to ActiveMQServerControl.listAddresses() and webconsole

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

michaelandrepearce-2
Github user pgfox commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1643
 
    @mtaylor I changed ActiveMQServerControlImpl#listAddresses(java.lang.String, int, int) to use
    ``
    server.getManagementService().getResources(AddressControl.class)
    ``
    rather than call
    ``
    server.getPostOffice().getAddresses()
    ``
    It was easier to get the memorySize and paging info from the AddressControl.
    It seems to work fine but just wondering if it is a bad idea as you avoided it initially?
   
    thanks
    Pat
   
     



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1643
 
    @pgfox There is some overhead in managing MBeans (creating, destroying and cleaning up).  The intent with the new console bits was to avoid any reliance on MBeans, so that going forward users could switch off MBean registration for certain object types and still be able to use management, via the ActiveMQServerControl.  The overhead doesn't seem that large at first, but once we start getting into the 1000s of addresses or connections it can start becoming significant.  Could you move the logic into a helper class or use the AddressInfo object instead?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1643: ARTEMIS-1502 added addressMemorySize an...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user pgfox closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1643


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1643: ARTEMIS-1502 added addressMemorySize and pagin...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user pgfox commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1643
 
    Thanks @mtaylor. I will close this PR as it is the wrong approach, maybe followup later with another PR.



---